Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update notes api for ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager#3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

massimiliano96
Copy link
Contributor

Changes

Add ListMixin to ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager

Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR updates the API for discussion note managers by replacing explicit mixin inheritance with a more concise CRUDMixin approach for both issue and merge request discussion notes.

  • Consolidates multiple explicit mixins (GetMixin, CreateMixin, UpdateMixin, DeleteMixin) into a single CRUDMixin for cleaner inheritance
  • Updates both ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager classes

@codecovCodecov
Copy link

codecovbot commentedJul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base(be25c16) to head(15ff9d5).

Additional details and impacted files
@@           Coverage Diff           @@##             main    #3233   +/-   ##=======================================  Coverage   97.32%   97.32%           =======================================  Files          98       98             Lines        6058     6058           =======================================  Hits         5896     5896             Misses        162      162
FlagCoverage Δ
api_func_v483.69% <100.00%> (-0.05%)⬇️
cli_func_v484.69% <100.00%> (ø)
unit90.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/v4/objects/notes.py100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovos
Copy link
Member

@massimiliano96 This looks good to me. Only suggestion is that in one of the commit messages add aCloses: #3180

So that when it gets merged the issue will get closed.

massimiliano96 reacted with thumbs up emoji

Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Thanks@massimiliano96

@JohnVillalovosJohnVillalovosenabled auto-merge (rebase)July 18, 2025 16:15
@JohnVillalovosJohnVillalovos merged commitf908f0e intopython-gitlab:mainJul 18, 2025
17 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@massimiliano96@JohnVillalovos
[8]ページ先頭
©2009-2025 Movatter.jp