NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: relax typing constraints for response action#3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

max-wittig merged 2 commits intomainfromchore/typing-bytes-any

Jan 28, 2025

Merged

chore: relax typing constraints for response action#3106

max-wittig merged 2 commits intomainfromchore/typing-bytes-any

Jan 28, 2025

Conversation

Copy link

Member

nejch commentedJan 28, 2025•
edited
Loading

Closes#3104

Documentation and testing

Please consider whether this PR needs documentation and tests.This is not required, but highly appreciated:

Documentation in the matchingdocs section
Unit tests and/orfunctional tests

nejch mentioned this pull request

Jan 28, 2025

mypy type checker fails on 5.4.0 ProjectFileManager raw method#3104

Closed

nejch assignedmax-wittig andJohnVillalovos

Jan 28, 2025

chore: relax typing constraints for response action

c74d324

Copy link

codecovbot commentedJan 28, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.80%. Comparing base(7f6fd5c) to head(ccda1f3).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #3106   +/-   ##=======================================  Coverage   96.80%   96.80%           =======================================  Files          97       97             Lines        6346     6346           =======================================  Hits         6143     6143             Misses        203      203

Flag	Coverage Δ
api_func_v4	`82.96% <ø> (-0.07%)`	⬇️
cli_func_v4	`83.04% <ø> (ø)`
unit	`89.34% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
gitlab/mixins.py	`92.85% <ø> (ø)`
gitlab/utils.py	`98.55% <ø> (ø)`
gitlab/v4/objects/artifacts.py	`100.00% <ø> (ø)`
gitlab/v4/objects/files.py	`100.00% <ø> (ø)`
gitlab/v4/objects/jobs.py	`82.75% <ø> (ø)`
gitlab/v4/objects/packages.py	`100.00% <ø> (ø)`
gitlab/v4/objects/projects.py	`98.93% <ø> (ø)`
gitlab/v4/objects/repositories.py	`85.88% <ø> (ø)`
gitlab/v4/objects/secure_files.py	`100.00% <ø> (ø)`
gitlab/v4/objects/snippets.py	`100.00% <ø> (ø)`