Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: use gitlab-runner:v17.7.1 for the CI#3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 2 commits intomainfromjlvillal/version_gitlab_runner
Jan 22, 2025

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedJan 21, 2025•
edited
Loading

Thelatest gitlab-runner image does not have thegitlab-runner user and it causes our tests to fail.

Closes:#3091

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/version_gitlab_runner branch 2 times, most recently from285208c to8cb5939CompareJanuary 22, 2025 00:00
The `latest` gitlab-runner image does not have the `gitlab-runner`user and it causes our tests to fail.Closes:#3091
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/version_gitlab_runner branch from8cb5939 to553f5b0CompareJanuary 22, 2025 00:08
@JohnVillalovosJohnVillalovos changed the titleci: use gitlab-runner:ubuntu-v17.7.1 for the CIci: use gitlab-runner:v17.7.1 for the CIJan 22, 2025
@codecovCodecov
Copy link

codecovbot commentedJan 22, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base(671e711) to head(5e169be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3093      +/-   ##==========================================+ Coverage   93.57%   96.72%   +3.14%==========================================  Files          96       96                Lines        6291     6291              ==========================================+ Hits         5887     6085     +198+ Misses        404      206     -198
FlagCoverage Δ
api_func_v482.89% <ø> (-0.05%)⬇️
cli_func_v482.91% <ø> (?)
unit89.15% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

see 11 files with indirect coverage changes

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@JohnVillalovos, looks good, just a question about the prints?

Previously the 'job_with_artifact' fixture could run forever. Now giveit up to 60 seconds to complete before failing.
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/version_gitlab_runner branch frombf0e534 to5e169beCompareJanuary 22, 2025 16:29
@nejchnejchenabled auto-merge (rebase)January 22, 2025 16:35
@nejchnejch merged commite4673d8 intomainJan 22, 2025
16 checks passed
@nejchnejch deleted the jlvillal/version_gitlab_runner branchJanuary 22, 2025 16:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Functional CLI test keeps hanging on GitHub CI.
2 participants
@JohnVillalovos@nejch
[8]ページ先頭
©2009-2025 Movatter.jp