Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add testing of Python 3.14#3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/py314
Oct 23, 2024
Merged

chore: add testing of Python 3.14#3023

nejch merged 1 commit intomainfromjlvillal/py314
Oct 23, 2024

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedOct 23, 2024•
edited
Loading

Also fix__annotations__ not working in Python 3.14 by using the
annotation on the 'class' instead of on the 'instance'

Closes:#3013

@JohnVillalovosJohnVillalovos marked this pull request as draftOctober 23, 2024 04:56
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewOctober 23, 2024 04:59
@JohnVillalovos
Copy link
MemberAuthor

@nejch This ended up being easier than I thought it would be.

@codecovCodecov
Copy link

codecovbot commentedOct 23, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base(3739b5d) to head(642ea08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3023      +/-   ##==========================================- Coverage   96.62%   96.62%   -0.01%==========================================  Files          95       95                Lines        6101     6099       -2     ==========================================- Hits         5895     5893       -2  Misses        206      206
FlagCoverage Δ
api_func_v482.62% <100.00%> (+0.10%)⬆️
cli_func_v482.91% <100.00%> (-0.01%)⬇️
unit88.75% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/base.py99.50% <100.00%> (-0.01%)⬇️

Also fix __annotations__ not working in Python 3.14 by using theannotation on the 'class' instead of on the 'instance'Closes:#3013
@nejch
Copy link
Member

Well that was easy :) thanks@JohnVillalovos

JohnVillalovos reacted with thumbs up emoji

@nejchnejch merged commit14d2a82 intomainOct 23, 2024
18 checks passed
@nejchnejch deleted the jlvillal/py314 branchOctober 23, 2024 15:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.14 breaks unit tests
2 participants
@JohnVillalovos@nejch
[8]ページ先頭
©2009-2025 Movatter.jp