NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Make repr() of project approval rules consistent with merge request approval rules#3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:mainfromholysoles:main

Oct 11, 2024

Merged

Make repr() of project approval rules consistent with merge request approval rules#3011

nejch merged 1 commit intopython-gitlab:mainfromholysoles:main

Oct 11, 2024

+141 −0

Conversation

Copy link

Contributor

holysoles commentedOct 9, 2024

Changes

The representation attribute forProjectMergeRequestApprovalRule isname (seehere), which makes sense based on the API documentation. However, the API forProjectApprovalRule isnearly the same, but we don't set the representation attribute toname for that class (seehere).

This MR sets_repr_attr for theProjectApprovalRule class , as well as adds a unit test for ensure we can list a project's approval rules, and callrepr() on it.

Documentation and testing

Please consider whether this PR needs documentation and tests.This is not required, but highly appreciated:

Documentation in the matchingdocs section
Unit tests and/orfunctional tests

holysoles changed the title~~fix(api): make repr() of project approval rules consistent with merge…~~Make repr() of project approval rules consistent with merge request approval rules

Oct 9, 2024

Copy link

codecovbot commentedOct 9, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base(9734ad4) to head(1605b2b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #3011   +/-   ##=======================================  Coverage   96.62%   96.62%           =======================================  Files          95       95             Lines        6100     6101    +1     =======================================+ Hits         5894     5895    +1  Misses        206      206