Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: use more python3.9 syntax#3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 1 commit intomainfromrefactor/py39
Feb 5, 2025
Merged

Conversation

nejch
Copy link
Member

@nejchnejch commentedOct 8, 2024
edited
Loading

Follow-up to#3005

Mostly done withpyupgrade --py39-plus and some manual cleanup.

@nejchnejch marked this pull request as draftOctober 8, 2024 15:49
@JohnVillalovos
Copy link
Member

JohnVillalovos commentedOct 8, 2024
edited
Loading

Cool! I was thinking about this too 🙂 Well thinking of stopping the use ofList[] type annotations and instead uselist[] style type annotations.

Thanks for doing this!

Once we (in reality you) get this done, we should do a follow-up adding the commit to.git-blame-ignore-revs which I'm sure you have already thought of.

nejch reacted with thumbs up emoji

@nejch
Copy link
MemberAuthor

Once we (in reality you) get this done, we should do a follow-up adding the commit to .git-blame-ignore-revs which I'm sure you have already thought of.

I was thinking of that as well, especially now that I see how big the diff is 😅 Maybe after this PR in case there's more rebasing etc.

I'll just need to tweak the type hint tests for this now.

@nejch
Copy link
MemberAuthor

I'll rebase this after#3083 to avoid too many conflicts there, and that will likely fix the typing issues altogether.

@nejchnejch marked this pull request as ready for reviewFebruary 5, 2025 18:27
@nejch
Copy link
MemberAuthor

@JohnVillalovos this one's a chunky one now, but mostly auto-generated 😅

@codecovCodecov
Copy link

codecovbot commentedFeb 5, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is99.71910% with1 line in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base(91c4f18) to head(49107f5).
Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
gitlab/v4/objects/merge_requests.py92.30%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3010      +/-   ##==========================================+ Coverage   97.25%   97.28%   +0.03%==========================================  Files          97       97                Lines        5932     5975      +43     ==========================================+ Hits         5769     5813      +44+ Misses        163      162       -1
FlagCoverage Δ
api_func_v483.48% <95.22%> (+0.06%)⬆️
cli_func_v484.50% <98.03%> (+0.12%)⬆️
unit90.07% <97.75%> (+0.07%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/__init__.py100.00% <ø> (ø)
gitlab/_backends/protocol.py100.00% <100.00%> (+7.14%)⬆️
gitlab/_backends/requests_backend.py98.80% <100.00%> (ø)
gitlab/base.py100.00% <100.00%> (ø)
gitlab/cli.py100.00% <100.00%> (ø)
gitlab/client.py98.73% <100.00%> (ø)
gitlab/config.py100.00% <100.00%> (ø)
gitlab/exceptions.py100.00% <100.00%> (ø)
gitlab/mixins.py91.34% <100.00%> (+0.04%)⬆️
gitlab/types.py98.24% <100.00%> (+0.03%)⬆️
... and38 more

Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@nejch

A lot of work there.

@JohnVillalovosJohnVillalovos merged commit4e90c11 intomainFeb 5, 2025
18 checks passed
@JohnVillalovosJohnVillalovos deleted the refactor/py39 branchFebruary 5, 2025 22:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nejch@JohnVillalovos

[8]ページ先頭

©2009-2025 Movatter.jp