Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(api): support list and delete for group service accounts#2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ka28kumar
Copy link
Contributor

add DeleteMixin, ListMixin to GroupServiceAccountManager and ObjectDeleteMixin to GroupServiceAccount

Changes

Documentation and testing

Please consider whether this PR needs documentation and tests.This is not required, but highly appreciated:

@ka28kumar
Copy link
ContributorAuthor

ka28kumar commentedSep 1, 2024
edited
Loading

@nejch ,
Can you check if this is functionally complete?
If it is, I'll start to add tests.

nejch reacted with heart emoji

@nejchnejch marked this pull request as ready for reviewSeptember 1, 2024 13:25
@codecovCodecov
Copy link

codecovbot commentedSep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base(bcef988) to head(b57fbf2).

Additional details and impacted files
@@           Coverage Diff           @@##             main    #2963   +/-   ##=======================================  Coverage   96.53%   96.53%           =======================================  Files          94       94             Lines        5997     5997           =======================================  Hits         5789     5789             Misses        208      208
FlagCoverage Δ
api_func_v482.49% <100.00%> (-0.12%)⬇️
cli_func_v483.47% <100.00%> (ø)
unit88.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/v4/objects/service_accounts.py100.00% <100.00%> (ø)

@nejch
Copy link
Member

Thanks for the contribution@ka28kumar I just got back to this.

Yes, this looks good! If you could add a few basic tests/asserts to the existing functional tests, this would be really appreciated! Thanks!

@ka28kumar
Copy link
ContributorAuthor

Will add. Thanks!

@nejch
Copy link
Member

Did you still want to add a few tests here@ka28kumar? Could just be a simple extension of:

service_account=group.service_accounts.create(

E.g.:

deftest_group_service_accounts(group):service_account=group.service_accounts.create(        {"name":"gitlab-service-account","username":"gitlab-service-account"}    )assertservice_account.name=="gitlab-service-account"assertservice_account.username=="gitlab-service-account"service_accounts=group.service_accounts.list()assertservice_accounts[0]==service_accountservice_account.delete()

Or something like that. Let me know otherwise we can also take over here!

@ka28kumar
Copy link
ContributorAuthor

I'm sorry I got occupied with some tasks. Feel free to take over.

@nejchnejch mentioned this pull requestNov 5, 2024
@nejchnejch changed the titlefeat(api): add DeleteMixin, ListMixin to GroupServiceAccountManager and ObjectDeleteMixin to GroupServiceAccountfeat(api): add support list and delete for group service accountsNov 5, 2024
@nejchnejch changed the titlefeat(api): add support list and delete for group service accountsfeat(api): support list and delete for group service accountsNov 5, 2024
@nejch
Copy link
Member

Thanks@ka28kumar let's get this merged and I've opened a follow-up for the tests.

@nejchnejchenabled auto-merge (squash)November 5, 2024 16:33
@nejchnejchforce-pushed the2946-extend-support-for-group-level-service-accounts branch fromb57fbf2 to6605d7aCompareNovember 5, 2024 16:33
@nejchnejch merged commit499243b intopython-gitlab:mainNov 5, 2024
16 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ka28kumar@nejch

[8]ページ先頭

©2009-2025 Movatter.jp