- Notifications
You must be signed in to change notification settings - Fork673
fix: Haveparticipants() method usehttp_list()#2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Previously it was using `http_get()` but the `participants` APIreturns a list of participants. Also by using this then we will warnif only a subset of the participants are returned.Closes:#2913
165f848 tofdee58fCompareThe `closed_by()` and `related_merge_requests()` API calls returnlists. So use the `http_list()` method.This will also warn the user if only a subset of the data is returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@JohnVillalovos!
Yes makes sense IMO this is why I'm in favor of using managers with ListMixin everywhere in place of custom methods as they often get it wrong or can get outdated it seems.
de2e4dd intomainUh oh!
There was an error while loading.Please reload this page.
Previously it was using
http_get()but theparticipantsAPI returns a list of participants. Also by using this then we will warn if only a subset of the participants are returned.Closes:#2913