Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(api): add support for gitlab service account#2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

SachinKSingh28
Copy link
Contributor

Adds support for creating group service account:https://docs.gitlab.com/ee/api/groups.html#service-accounts

#2812

@codecovCodecov
Copy link

codecovbot commentedMay 4, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base(7ec3189) to head(5256a9c).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #2851      +/-   ##==========================================- Coverage   96.52%   96.51%   -0.02%==========================================  Files          90       91       +1       Lines        5872     5907      +35     ==========================================+ Hits         5668     5701      +33- Misses        204      206       +2
FlagCoverage Δ
api_func_v482.39% <100.00%> (+0.15%)⬆️
cli_func_v483.61% <100.00%> (+0.02%)⬆️
unit88.33% <100.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
gitlab/v4/objects/__init__.py100.00% <100.00%> (ø)
gitlab/v4/objects/groups.py95.90% <100.00%> (+0.04%)⬆️
gitlab/v4/objects/service_accounts.py100.00% <100.00%> (ø)

... and1 file with indirect coverage changes

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot@SachinKSingh28! Looks good. I just have a few comments 🙇

@SachinKSingh28SachinKSingh28force-pushed thefeat/add-service-account-management branch 2 times, most recently fromb1f676a to148fb7eCompareMay 9, 2024 02:48
@JohnVillalovosJohnVillalovosforce-pushed thefeat/add-service-account-management branch 2 times, most recently from77ca5e2 to53dcd8cCompareMay 14, 2024 01:19
@SachinKSingh28
Copy link
ContributorAuthor

@nejch addressed your comments! Ready for a review again.

@SachinKSingh28SachinKSingh28force-pushed thefeat/add-service-account-management branch from8b92a39 toe68c9e2CompareMay 15, 2024 21:32
@JohnVillalovosJohnVillalovosforce-pushed thefeat/add-service-account-management branch frome68c9e2 toc628ab3CompareMay 16, 2024 23:46
@nejch
Copy link
Member

Thanks again@SachinKSingh28, I applied a nit left over from the first round myself so we don't block this anymore. I'll squash and merge 👍

SachinKSingh28 reacted with heart emoji

@nejchnejchenabled auto-merge (squash)May 17, 2024 10:30
@nejchnejchforce-pushed thefeat/add-service-account-management branch from5256a9c to61b4f7fCompareMay 17, 2024 10:30
@nejchnejch merged commitb187dea intopython-gitlab:mainMay 17, 2024
@SachinKSingh28SachinKSingh28 deleted the feat/add-service-account-management branchMay 17, 2024 12:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch requested changes

@TimKnight-DWPTimKnight-DWPTimKnight-DWP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@SachinKSingh28@nejch@TimKnight-DWP
[8]ページ先頭
©2009-2025 Movatter.jp