- Notifications
You must be signed in to change notification settings - Fork673
Fixed repository_compare examples#282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch, thank you!
Could you fix the 2 problems?
docs/gl_objects/projects.py Outdated
| @@ -178,11 +178,11 @@ | |||
| result = project.repository_compare('master', 'branch1') | |||
| # get the commits | |||
| for i in commit: | |||
| print(result.commits) | |||
| for commit in result.commits: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
result is a dict, so you needresult['commits'] here.
docs/gl_objects/projects.py Outdated
| # get the diffs | ||
| for file_diff incommit.diffs: | ||
| for file_diff inresult.diffs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here for diffs.
You are right, I fixed them. |
Looks good, thank you for the quick update! |
No description provided.