Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(job_token_scope): support Groups in job token allowlist API#2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

TimKnight-DWP
Copy link
Contributor

Builds ontop of:#2767 and#2790

Closes#2762

Adds support for adding Group to job_token_allowlist:https://docs.gitlab.com/ee/api/project_job_token_scopes.html#add-a-group-to-a-cicd-job-token-allowlist

adam-moss reacted with rocket emoji
@TimKnight-DWP
Copy link
ContributorAuthor

NOTE: Group allowlist functionality is due in16.10 eta: March 21st

I will develop tests using thenightly builds image, and leave in draft until 16.10 is released

@TimKnight-DWPTimKnight-DWPforce-pushed thefeat/group-allowlist branch 2 times, most recently from5f27abe to5aa3701CompareMarch 5, 2024 16:01
@TimKnight-DWPTimKnight-DWP marked this pull request as ready for reviewMarch 5, 2024 16:06
@TimKnight-DWP
Copy link
ContributorAuthor

Ready for Review
Marked ready to review, tests are passing against thenightly build which includes the Group allowlist changes

For merge in will need to mark as XFail or have a feature flag based on if 16.10+ is active or no?

@codecovCodecov
Copy link

codecovbot commentedMar 5, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base(7ec3189) to head(ee826ad).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #2816      +/-   ##==========================================- Coverage   96.52%   96.50%   -0.03%==========================================  Files          90       90                Lines        5872     5889      +17     ==========================================+ Hits         5668     5683      +15- Misses        204      206       +2
FlagCoverage Δ
api_func_v482.37% <70.37%> (+0.13%)⬆️
cli_func_v483.59% <70.37%> (+0.01%)⬆️
unit88.30% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
gitlab/v4/objects/job_token_scope.py100.00% <100.00%> (ø)

... and1 file with indirect coverage changes

@TimKnight-DWP
Copy link
ContributorAuthor

@nejch built on the work you started and some of the discussions we had a few months back, this adds support for managing the CI Job Token via python-gitlab.

@TimKnight-DWP
Copy link
ContributorAuthor

Hi@nejch ,@JohnVillalovos ,@max-wittig ,@bufferoverflow

Myself and@SachinKSingh28 among others will be working on a project to migrate from Gitlab-SAAS to Dedicate, alongside our work on GitLabForm project we will be adding in Enterprise feature sets to python-gitlab.

Would there be a good way to discuss a ways of working that is useful for the demands on your time, and if it would be helpful for us to also take on Maintainership of the project? As it's a key part of our infrastructure here at the DWP (a UK Gov public sector department)

@JohnVillalovos
Copy link
Member

Would there be a good way to discuss a ways of working that is useful for the demands on your time, and if it would be helpful for us to also take on Maintainership of the project? As it's a key part of our infrastructure here at the DWP (a UK Gov public sector department)

Nothing personal but after what happened to XZ project [1]. Having people asking to become maintainers is looked warily by me.

https://news.ycombinator.com/item?id=39865810

But I would be up for a video-conference if@nejch would like to do it. Doing a hackathon or something along those lines could be fun.

bufferoverflow and TimKnight-DWP reacted with thumbs up emoji

@JohnVillalovos
Copy link
Member

Overall this is looking pretty good to me. My suggestions are mostly minor.

TimKnight-DWP reacted with thumbs up emoji

@TimKnight-DWP
Copy link
ContributorAuthor

TimKnight-DWP commentedMay 8, 2024
edited
Loading

Would there be a good way to discuss a ways of working that is useful for the demands on your time, and if it would be helpful for us to also take on Maintainership of the project? As it's a key part of our infrastructure here at the DWP (a UK Gov public sector department)

Nothing personal but after what happened to XZ project [1]. Having people asking to become maintainers is looked warily by me.

https://news.ycombinator.com/item?id=39865810

But I would be up for a video-conference if@nejch would like to do it. Doing a hackathon or something along those lines could be fun.

@JohnVillalovos -> Oh absolutely! We work in Security here, and having seen what happen with XZ is why I've not wanted to be too pushy 👍

We would be up for having a video-conference call etc. We're on BST

@TimKnight-DWP
Copy link
ContributorAuthor

Updated PR

Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking good to me. Left a couple of comments about trying to get the code coverage test to pass.

Hopefully@nejch can do a review on this too.

TimKnight-DWP reacted with heart emoji
@TimKnight-DWP
Copy link
ContributorAuthor

@JohnVillalovos updated once more, I certainly intended to have already covered those paths, but clearly hadn't so done now 👍

JohnVillalovos reacted with thumbs up emoji

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
@JohnVillalovosJohnVillalovosenabled auto-merge (squash)May 13, 2024 21:28
@JohnVillalovosJohnVillalovos merged commit2d1b749 intopython-gitlab:mainMay 13, 2024
@TimKnight-DWPTimKnight-DWP deleted the feat/group-allowlist branchMay 14, 2024 07:06
@TimKnight-DWP
Copy link
ContributorAuthor

Thanks for the merge@JohnVillalovos

If you wanted to have a chat, we can talk through what we're doing with GitLab on our end and how that'll interface with python-gitlab.

Hopefully this calendly link should work:https://calendly.com/tim-knight1/30min

@JohnVillalovos
Copy link
Member

Thanks for the merge@JohnVillalovos

If you wanted to have a chat, we can talk through what we're doing with GitLab on our end and how that'll interface with python-gitlab.

Hopefully this calendly link should work:https://calendly.com/tim-knight1/30min

Meeting sounds great to me, but I would like to wait for@nejch to join. I'm assuming that he is on vacation or something as I haven't heard from him for a bit.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SachinKSingh28SachinKSingh28SachinKSingh28 left review comments

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support /projects/:id/job_token_scope/allowlist
4 participants
@TimKnight-DWP@JohnVillalovos@SachinKSingh28@nejch

[8]ページ先頭

©2009-2025 Movatter.jp