- Notifications
You must be signed in to change notification settings - Fork676
test: add api integration test for ci_cd_token allowlist#2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
TimKnight-DWP wants to merge19 commits intopython-gitlab:feat/job-token-scope-allowlistfromTimKnight-DWP:feat/job-token-scope-allowlist
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* fix(cli): allow exclusive arguments as optionalThe CLI takes its arguments from the RequiredOptional, which has three fields: required, optional, and exclusive. In practice, the exclusive options are not defined as either required or optional, and would not be allowed in the CLI. This changes that, so that exclusive options are also added to the argument parser. * fix(cli): inform argument parser that options are mutually exclusive * fix(cli): use correct exclusive options, add unit testClosespython-gitlab#2769
The version of `black` needs to be updated to be in sync with what isin `requirements-lint.txt`
* feat(api): allow updating protected branchesClosespython-gitlab#2390
2 tasks
748f4cd toff9e76cCompareSigned-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
ff9e76c to4203becCompareSigned-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@## feat/job-token-scope-allowlist #2797 +/- ##==================================================================+ Coverage 88.25% 96.45% +8.19%================================================================== Files 90 90 Lines 5866 5888 +22 ==================================================================+ Hits 5177 5679 +502+ Misses 689 209 -480
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Relates to:#2767 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding api integration test based off my percieved understanding of the underlying gitlab api and the design as currently documented in the open PR