Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(api): add additional parameter to project/group iteration search#2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

cristianocasella
Copy link
Contributor

Relates to#2795

Changes

Added "in" parameter to define where te search should be performed in a iteration list.

Documentation and testing

Please consider whether this PR needs documentation and tests.This is not required, but highly appreciated:

@cristianocasellacristianocasella changed the titlefeat(api): add "in" parameter to project/group iteration searchfeat(api): add additional parameter to project/group iteration searchFeb 12, 2024
@codecovCodecov
Copy link

codecovbot commentedFeb 12, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base(7ec3189) to head(9a7f3e2).
Report is 63 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #2796   +/-   ##=======================================  Coverage   96.52%   96.53%           =======================================  Files          90       91    +1       Lines        5872     5912   +40     =======================================+ Hits         5668     5707   +39- Misses        204      205    +1
FlagCoverage Δ
api_func_v482.39% <100.00%> (+0.15%)⬆️
cli_func_v483.64% <100.00%> (+0.06%)⬆️
unit88.36% <100.00%> (+0.06%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
gitlab/v4/objects/iterations.py100.00% <100.00%> (ø)

... and1 file with indirect coverage changes

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for the rework and documenting this@cristianocasella! Just a few more nits from my side, let me know if you have any questions.

@cristianocasellacristianocasellaforce-pushed theiteration-search-in branch 2 times, most recently from09bec19 to74345fbCompareFebruary 12, 2024 17:28
@cristianocasellacristianocasellaforce-pushed theiteration-search-in branch 2 times, most recently from663e36d tofd1f8fbCompareApril 10, 2024 07:08
@nejchnejchforce-pushed theiteration-search-in branch fromfd1f8fb to1c50639CompareMay 20, 2024 09:50
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@cristianocasella I've left one final round of comments/nits that also need an additional import based on your latest comment. Let me know and if you can update this then we can go ahead and merge!

@cristianocasella
Copy link
ContributorAuthor

Going for a final rebase to include all the last adds

@cristianocasellacristianocasellaforce-pushed theiteration-search-in branch 3 times, most recently fromb3589ef to7e8a995CompareMay 20, 2024 10:32
@nejchnejchenabled auto-merge (squash)May 22, 2024 11:11
@nejchnejch merged commit623dac9 intopython-gitlab:mainMay 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@cristianocasella@nejch
[8]ページ先頭
©2009-2025 Movatter.jp