Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Docs 📖: Add link to gitlab docs on obtaining a token#278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

asfaltboy
Copy link
Contributor

I find these sort of links very user friendly 😅

@asfaltboyasfaltboy changed the titleDocs: Add link to gitlab docs on obtaining a tokenDocs 📖: Add link to gitlab docs on obtaining a tokenJun 23, 2017
Copy link
Contributor

@gpocentekgpocentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very good idea, thank you. Can you update the sentence with my suggestions?

Thanks!

docs/cli.rst Outdated
@@ -80,13 +80,16 @@ section.
- URL for the GitLab server
* - ``private_token``
- Your user token. Login/password is not supported.
Please refer `the official documentation`__ to learn how to obtain a token.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can removePlease here as you're not asking for permission to the reader ;)

I'm not a native english speaker but I believe "Refer to the official doc..." is better.

asfaltboy reacted with thumbs up emoji
I find these sort of links very user friendly 😅
@asfaltboy
Copy link
ContributorAuthor

Thanks@gpocentek , removed "Please" and amended the commit.

@gpocentek
Copy link
Contributor

Thanks! The test failures are not related to this patch so let's merge!

@gpocentekgpocentek merged commit657f011 intopython-gitlab:masterAug 4, 2017
@asfaltboyasfaltboy deleted the link-docs-gitlab-token branchAugust 4, 2017 18:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpocentekgpocentekgpocentek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@asfaltboy@gpocentek

[8]ページ先頭

©2009-2025 Movatter.jp