I don't understand why the integration test fails. It works on my local instance, and the code seems to make sense:

p_b.allow_force_push = Truep_b.save()p_b = project.protectedbranches.get("*-stable")assert p_b.allow_force_push

I don't understand why the integration test fails. It works on my local instance, and the code seems to make sense:

p_b.allow_force_push = Truep_b.save()p_b = project.protectedbranches.get("*-stable")assert p_b.allow_force_push

Just a guess, but it may need to use thewait_for_sidekiq() function. As the GitLab server may still be processing thesave() asynchronously while doing theget().

functional/api/test_merge_requests.py has usage ofwait_for_sidekiq()

Sadly our functional tests still run against 15.4 (yes, I know!) because we had issues with flaky and failing tests when upgrading. This was introduced in 15.6 so this is sort of expected. We need to take the time to fix that soon I guess.

I would suggest adding a skip or xfail (I forget if we still have a decorator for gitlab versions - that would be ideal. At least we have agitlab_version fixture so you could conditionally test those few lines as well.

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(48726fd) 96.48% compared to head(cef02d2) 96.52%.
Report is 3 commits behind head on main.

@@            Coverage Diff             @@##             main    #2771      +/-   ##==========================================+ Coverage   96.48%   96.52%   +0.03%==========================================  Files          90       90                Lines        5866     5873       +7     ==========================================+ Hits         5660     5669       +9+ Misses        206      204       -2

Is this expected to also work withprotectedbranch.allowed_to_push orprotectedbranch.push_access_levels ?

The PATCH api requires to sendallowed_to_push attribute, but the returned attribute ispush_access_levels, as documented in the API and examples:https://docs.gitlab.com/ee/api/protected_branches.html#example-update-a-push_access_level-record

So using the python-gitlab library to modify thepush_access_levels attribute that the object has and then calling.save() appears to do nothing, and the python object has noallowed_to_push attribute to modify.

I made this to supportallow_force_push, and if anything else worked that would be a bonus. I expectallowed_to_push to work.

It is indeed a pain that the API expects different information than it returns. I have been bitten by this before, and I think I saw an issue about this in some other context, but I can't find it right now. Unfortunately, there is not really a clear solution for this.

Perhaps it's better to create a new issue for your problem. This pull request is already closed so comments here will get out of sight.