Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(cli): support binary files with@ notation#2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/issue_2752
Jan 4, 2024

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedDec 28, 2023•
edited
Loading

Support binary files being used in the CLI with arguments using the
@ notation. For example--avatar @/path/to/avatar.png

Also explicitly catch the common FileNotFoundError and PermissionError
exceptions.

Remove the bare exception handling. We would rather have the full
traceback of any exceptions that we don't know about and add them
later if needed.

Closes:#2752

@JohnVillalovosJohnVillalovos marked this pull request as draftDecember 28, 2023 22:29
@codecov
Copy link

codecovbot commentedDec 28, 2023•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(b8824a6) 96.47% compared to head(a4d0b78) 96.47%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #2753   +/-   ##=======================================  Coverage   96.47%   96.47%           =======================================  Files          89       89             Lines        5814     5819    +5     =======================================+ Hits         5609     5614    +5  Misses        205      205
FlagCoverage Δ
api_func_v482.36% <12.50%> (-0.06%)⬇️
cli_func_v483.63% <75.00%> (+0.08%)⬆️
unit88.17% <75.00%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
gitlab/cli.py100.00% <100.00%> (ø)

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/issue_2752 branch 5 times, most recently frombab6802 to08630efCompareDecember 28, 2023 23:45
@JohnVillalovosJohnVillalovos changed the titlewip: testing thingsfix(cli): support binary files with@ notationDec 28, 2023
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewDecember 28, 2023 23:46
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@JohnVillalovos thanks a lot, looks nice! Maybe we can just add that one additional I/O error that I think we can expect to happen with OS paths?

Support binary files being used in the CLI with arguments using the`@` notation. For example `--avatar @/path/to/avatar.png`Also explicitly catch the common OSError exception, which is theparent exception for things like: FileNotFoundError, PermissionErrorand more exceptions.Remove the bare exception handling. We would rather have the fulltraceback of any exceptions that we don't know about and add themlater if needed.Closes:#2752
@nejchnejchenabled auto-merge (rebase)January 4, 2024 17:02
@nejchnejch merged commit57749d4 intomainJan 4, 2024
@nejchnejch deleted the jlvillal/issue_2752 branchJanuary 4, 2024 17:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI: Reading values from files does not support binary files

3 participants

@JohnVillalovos@nejch
[8]ページ先頭
©2009-2025 Movatter.jp