- Notifications
You must be signed in to change notification settings - Fork674
fix(cli): fix action display in --help when there are few actions#2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nejch left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for the fix@jouve, nice find.
I took the liberty of refactoring this a bit to be more readable (subjective of course!) and to fix a bug where the help indent was the length of all choices combined instead of the longest choice (which I think is the behavior you wanted. You're still set as the commit author of course. Hope that's alright with you! Thanks again!
jouve commentedOct 10, 2023
no problem, I'd rather you do that than back and forth commits/ comments in the PR :) the length I used was to try to keep "Action to execute ..." from but I think your idea will look better. |
glensc commentedNov 16, 2023
@nejch the find is mine: |
Uh oh!
There was an error while loading.Please reload this page.
Changes
display --help actions correctly when there are few actions.
fix#2656
Documentation and testing
Please consider whether this PR needs documentation and tests.This is not required, but highly appreciated: