NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore(deps): update dependency requests to v2.31.0 [security]#2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 2 commits intomainfromjlvillal/requests

Aug 19, 2023

Merged

chore(deps): update dependency requests to v2.31.0 [security]#2627

nejch merged 2 commits intomainfromjlvillal/requests

Aug 19, 2023

Conversation

Copy link

Member

JohnVillalovos commentedJul 24, 2023•
edited
Loading

~~At the moment need to pinurllib3<2 as unit tests break.~~

Closes:#2626

JohnVillalovos requested a review fromnejch

July 24, 2023 20:27

JohnVillalovos force-pushed thejlvillal/requests branch 2 times, most recently from723afdf tocc7718cCompare

July 25, 2023 21:07

JohnVillalovos mentioned this pull request

Jul 27, 2023

chore: UserWarning if body provided for unsupported statusgetsentry/responses#658

Closed

test: fix failing tests that use 204 (No Content) plus content

3cd928c

urllib3>=2 now checks for expected content length. Also codes 204 and304 are set to expect a content length of 0 [1]So in the unit tests stop setting content to return in thesesituations.[1]https://github.com/urllib3/urllib3/blob/88a707290b655394aade060a8b7eaee83152dc8b/src/urllib3/response.py#L691-L693

JohnVillalovos force-pushed thejlvillal/requests branch fromcc7718c to1dd85ecCompare

August 2, 2023 14:18

Copy link

MemberAuthor

JohnVillalovos commentedAug 2, 2023•
edited
Loading

@nejch When you have some time would appreciate a review on this. Will fix some of the problems we are seeing where the automated dependency updates are failing.

chore(deps): update dependency requests to v2.31.0 [security]

053b030

Also update dependency `responses==0.23.3` as it provides support for`urllib3>=2`Closes:#2626

JohnVillalovos force-pushed thejlvillal/requests branch from1dd85ec to053b030Compare

August 2, 2023 15:34

Copy link

Member

nejch commentedAug 19, 2023

@nejch When you have some time would appreciate a review on this. Will fix some of the problems we are seeing where the automated dependency updates are failing.

Thanks a lot@JohnVillalovos!

Weird about the upstream discussions.. I was pretty sure GitLab actually had{"message": "204 No Content"} in some responses for 204 there, otherwise I'm not sure why I'd add that there 🤷