NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

fix(cli): add _from_parent_attrs to user-project manager (#2558)#2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 2 commits intopython-gitlab:mainfromw7089:fix-2558

Oct 12, 2023

Merged

fix(cli): add _from_parent_attrs to user-project manager (#2558)#2588

nejch merged 2 commits intopython-gitlab:mainfromw7089:fix-2558

Oct 12, 2023

Conversation

Copy link

w7089 commentedMay 31, 2023

Changes

setting_from_parent_attrs onUserProjectManager and using it in itslist methodresolves#2558 and allows specific user's projects to be returned successfully.

The inspiration for the fix came from_from_parent_attrs = {"user_id": "id"} line ofUserProjectManager.

Tested by running below script with arguments:user-project list --user-id [user_id]

import gitlabgl = gitlab.GitLab(...)gl.auth()import gitlab.cli as clicli.main()

JohnVillalovos force-pushed thefix-2558 branch from5a728cc to5984333Compare

July 6, 2023 18:26

JohnVillalovos force-pushed thefix-2558 branch from5984333 to307338eCompare

August 27, 2023 18:35

Copy link

codecovbot commentedAug 27, 2023•
edited
Loading

Codecov Report

Merging#2588 (0f1d0d9) intomain (6ce2149) willincrease coverage by0.00%.
The diff coverage is50.00%.

@@           Coverage Diff           @@##             main    #2588   +/-   ##=======================================  Coverage   96.35%   96.35%           =======================================  Files          87       87             Lines        5656     5657    +1     =======================================+ Hits         5450     5451    +1  Misses        206      206