Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: adapt functional tests for GitLab 15.8#2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
JohnVillalovos wants to merge4 commits intomainfromjlvillal/password

Conversation

JohnVillalovos
Copy link
Member

No description provided.

@JohnVillalovos
Copy link
MemberAuthor

@nejch If you want to explore the other tests that are failing due to the GitLab version bump feel free. Otherwise I will try to get to it tomorrow after I finish my work day.

nejch reacted with thumbs up emoji

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/password branch 2 times, most recently from43c70c5 toeb56aadCompareFebruary 13, 2023 08:16
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/password branch 4 times, most recently frome5db411 toaa413ebCompareFebruary 13, 2023 16:29
@nejchnejch changed the titleUse stronger passwords and bump GitLab versiontest: adapt functional tests for GitLab 15.8Feb 13, 2023
@nejch
Copy link
Member

nejch commentedFeb 13, 2023•
edited
Loading

@JohnVillalovos I looked at the bulk import failures. It's now disabled by default with 15.8 on the instance and gives a cryptic 404 (filed it upstream:https://gitlab.com/gitlab-org/gitlab/-/issues/391545). I can try to tackle that as I worked on bulk imports.

image

But I havent looked at the user deletion issues yet. This might take a little more work to upgrade.

JohnVillalovos reacted with thumbs up emoji

@JohnVillalovos
Copy link
MemberAuthor

@nejch Thanks for investigating. This is probably going to be a weekend project for me.

Newer versions of GitLab will refuse to create a user with a weakpassword. In order for us to move to a newer GitLab version in testinguse a stronger password for the tests that create a user.
Now GitLab is returning two custom attributes for a user. So don'tassert that there are no custom attributes on a new user.[1]https://gitlab.com/gitlab-org/gitlab/-/merge_requests/108250
Switch to newer version of GitLab for testing.
@nejch
Copy link
Member

I believe this was now merged as part of another PR.@JohnVillalovos if you think we missed something please reopen 🙇 (I know some parts are disabled at the moment, but still in the code).

@nejchnejch closed thisMay 17, 2024
@JohnVillalovos
Copy link
MemberAuthor

I believe this was now merged as part of another PR.@JohnVillalovos if you think we missed something please reopen 🙇 (I know some parts are disabled at the moment, but still in the code).

Agreed! Thanks.

@JohnVillalovosJohnVillalovos deleted the jlvillal/password branchMay 17, 2024 13:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lmilbaumlmilbaumlmilbaum left review comments

@nejchnejchnejch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@nejch@lmilbaum
[8]ページ先頭
©2009-2025 Movatter.jp