Codecov Report

Merging#2442 (722312e) intomain (3d7ca1c) willincrease coverage by4.29%.
The diff coverage is84.21%.

📣 This organization is not using Codecov’sGitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories.Learn more

@@            Coverage Diff             @@##             main    #2442      +/-   ##==========================================+ Coverage   91.85%   96.15%   +4.29%==========================================  Files          86       87       +1       Lines        5646     5663      +17     ==========================================+ Hits         5186     5445     +259+ Misses        460      218     -242

Flags with carried forward coverage won't be shown.Click here to find out more.

/rerun-all

Thanks. Can the commit message have some details on the "why" of this PR?

I still would like to see the description be put into the commit message.

At the moment all I see is:

$ git show --no-patchcommit 958d35d3c3d1755edf651cb15f5d1397ca571cc6 (HEAD -> refs/heads/protocol, refs/remotes/origin/protocol)Author: Liora Milbaum <liora@lmb.co.il>Date:   Mon Dec 26 06:39:58 2022 +0200    feat: PEP 544 – Protocols: Structural subtyping (static duck typing)

/rerun-all

Thanks. Can the commit message have some details on the "why" of this PR?

I still would like to see the description be put into the commit message.

At the moment all I see is:

As an alternative we can squash-merge and it will link to the PR which has much more context than we would usually put in commit messages. WDYT@JohnVillalovos

As an alternative we can squash-merge and it will link to the PR which has much more context than we would usually put in commit messages. WDYT@JohnVillalovos

That is okay if it is in the commit message. I want the details in the Git log. Not only on GitHub. What if the project gets moved to GitLab in the future. That information can disappear if it isn't in the git repository.

Seems relatively easy to take the description above and put it in the commit message. But maybe I am missing something?

Sure, we can maybe copy it during the squash merge in the description field and it'll appear in the body. I've already sneakily edited the PR title a bit 😺

GitLab's importer is actually quite good these days so it would preserve the commit-to-MR associations, I personally like that over long commit bodies as it includes the review context but that's subjective of course.

I'll approve for now, and see if there's anything else to cover :)

As an alternative we can squash-merge and it will link to the PR which has much more context than we would usually put in commit messages. WDYT@JohnVillalovos

That is okay if it is in the commit message. I want the details in the Git log. Not only on GitHub. What if the project gets moved to GitLab in the future. That information can disappear if it isn't in the git repository.

Seems relatively easy to take the description above and put it in the commit message. But maybe I am missing something?

I added the description in the body and reworded a bit during merge,4afeaff.