Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: Migrate MultipartEncoder to RequestsBackend#2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 2 commits intopython-gitlab:mainfromlmilbaum:MultipartEncoder
Dec 19, 2022

Conversation

lmilbaum
Copy link

No description provided.

nejch reacted with thumbs up emoji
@codecov-commenter
Copy link

codecov-commenter commentedDec 11, 2022•
edited
Loading

Codecov Report

Merging#2421 (48afd2c) intomain (6682808) willdecrease coverage by0.00%.
The diff coverage is88.23%.

@@            Coverage Diff             @@##             main    #2421      +/-   ##==========================================- Coverage   96.16%   96.16%   -0.01%==========================================  Files          85       85                Lines        5580     5579       -1     ==========================================- Hits         5366     5365       -1  Misses        214      214
FlagCoverage Δ
api_func_v482.70% <88.23%> (-0.01%)⬇️
cli_func_v482.95% <82.35%> (-0.01%)⬇️
unit87.54% <88.23%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/http_backends/requests_backend.py95.65% <87.50%> (-4.35%)⬇️
gitlab/client.py98.93% <100.00%> (+0.37%)⬆️

@lmilbaumlmilbaumforce-pushed theMultipartEncoder branch 2 times, most recently from12bc632 to222c89aCompareDecember 19, 2022 10:26
@lmilbaumlmilbaum marked this pull request as ready for reviewDecember 19, 2022 10:28
@lmilbaum
Copy link
Author

@nejch Could you please place a latedok-to-test on this PR? I want to verify the error is not caused by a flaky test.

@nejch
Copy link
Member

@nejch Could you please place a latedok-to-test on this PR? I want to verify the error is not caused by a flaky test.

@lmilbaum you shoul have Triage rights now (check your email if not), so you should be able to do so yourself in the future.

@lmilbaum
Copy link
Author

@nejch Could you please place a latedok-to-test on this PR? I want to verify the error is not caused by a flaky test.

@lmilbaum you shoul have Triage rights now (check your email if not), so you should be able to do so yourself in the future.

yay. Thank you for trusting me.

@lmilbaum
Copy link
Author

@nejch Could you please place a latedok-to-test on this PR? I want to verify the error is not caused by a flaky test.

yup. It was a flaky test.

@nejchnejch merged commit43b369f intopython-gitlab:mainDec 19, 2022
@lmilbaumlmilbaum deleted the MultipartEncoder branchDecember 19, 2022 18:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

@JohnVillalovosJohnVillalovosAwaiting requested review from JohnVillalovos

Assignees

@lmilbaumlmilbaum

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lmilbaum@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp