NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

refactor: move Response object to backends#2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:mainfromlmilbaum:response

Dec 19, 2022

Merged

refactor: move Response object to backends#2420

nejch merged 1 commit intopython-gitlab:mainfromlmilbaum:response

Dec 19, 2022

Conversation

Copy link

lmilbaum commentedDec 10, 2022

No description provided.

Copy link

codecov-commenter commentedDec 10, 2022•
edited
Loading

Codecov Report

Merging#2420 (62e535b) intomain (c7cf0d1) willincrease coverage by0.00%.
The diff coverage is95.23%.

@@           Coverage Diff           @@##             main    #2420   +/-   ##=======================================  Coverage   96.13%   96.13%           =======================================  Files          84       84             Lines        5534     5542    +8     =======================================+ Hits         5320     5328    +8  Misses        214      214

Flag	Coverage Δ
api_func_v4	`82.60% <90.47%> (+0.02%)`	⬆️
cli_func_v4	`82.91% <80.95%> (+0.02%)`	⬆️
unit	`87.45% <90.47%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/client.py	`98.55% <90.90%> (ø)`
gitlab/http_backends/__init__.py	`100.00% <100.00%> (ø)`
gitlab/http_backends/requests_backend.py	`100.00% <100.00%> (ø)`

lmilbaum force-pushed theresponse branch from4623db4 to16ef0a8Compare

December 10, 2022 13:13

lmilbaum changed the title~~Response~~refactor: RequestsResponse

Dec 10, 2022

lmilbaum marked this pull request as ready for review

December 10, 2022 14:01

lmilbaum force-pushed theresponse branch 2 times, most recently from459af58 to62e535bCompare

December 11, 2022 11:01

nejch reviewed

Dec 11, 2022

View reviewed changes

gitlab/client.py OutdatedShow resolvedHide resolved

lmilbaum force-pushed theresponse branch 2 times, most recently fromc1eb547 toccb13edCompare

December 12, 2022 04:33

lmilbaum requested a review fromnejch

December 12, 2022 04:51

lmilbaum force-pushed theresponse branch fromccb13ed toa467937Compare

December 12, 2022 20:47

Copy link

Author

lmilbaum commentedDec 15, 2022

@nejch Kindest reminder

nejch requested changes

Dec 18, 2022

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for the delay@lmilbaum, I've looked at this a few times now and looks ok to me, I'm just not 100% sure how we're going to split this later for streaming responses. Let's try this, just one more question.