Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Use the ProjectIterationManager within the Project object#2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hollerdawg
Copy link

The Project object was previously using the GroupIterationManager resulting in the incorrect API endpoint being used. Utilize the correct ProjectIterationManager instead.

Resolves#2403

nejch reacted with thumbs up emoji
The Project object was previously using the GroupIterationManagerresulting in the incorrect API endpoint being used. Utilize the correctProjectIterationManager instead.Resolvespython-gitlab#2403
@codecov-commenter
Copy link

Codecov Report

Merging#2404 (1e63822) intomain (22b11db) willnot change coverage.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #2404   +/-   ##=======================================  Coverage   95.97%   95.97%           =======================================  Files          80       80             Lines        5342     5342           =======================================  Hits         5127     5127             Misses        215      215
FlagCoverage Δ
api_func_v483.73% <100.00%> (ø)
cli_func_v482.38% <100.00%> (ø)
unit87.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/projects.py98.85% <100.00%> (ø)

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the catch@hollerdawg!

Note to self, this was probably an oversight when I added it initially because "project iterations" don't really exist anymore and associated group iterations are returned instead. So we might need to revisit this a bit if there's any kind of iteration-level endpoint later.

@nejchnejch merged commit44f05dc intopython-gitlab:mainDec 3, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

project iterations are broken
3 participants
@hollerdawg@codecov-commenter@nejch

[8]ページ先頭

©2009-2025 Movatter.jp