Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: validate httpx package is not installed by default#2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:mainfromlmilbaum:install
Nov 23, 2022

Conversation

lmilbaum
Copy link

No description provided.

@lmilbaum
Copy link
Author

@nejch@JohnVillalovos Is it possible theTest / functional (cli_func_v4)workflow is flaky? This is not the first time my PRs are hitting a similar failure. A rerun usually ends ok.

@JohnVillalovos
Copy link
Member

@nejch@JohnVillalovos Is it possible theTest / functional (cli_func_v4)workflow is flaky? This is not the first time my PRs are hitting a similar failure. A rerun usually ends ok.

That new test seems to be flaky. Now who is responsible for that? /me checksgit blame and sees he wrote it 😳

So looks like I need to spend some more time makingtest_cancel_merge_when_pipeline_succeeds more reliable. Created issue#2383

lmilbaum reacted with thumbs up emoji

@lmilbaum
Copy link
Author

/rerun-all

@JohnVillalovos
Copy link
Member

JohnVillalovos commentedNov 19, 2022
edited
Loading

Can this be done usingtox? So that these tests can be run locally instead of only being able to be done in the CI?

Doesn't have to be a default test that is run intox but would be good if it can be run locally.

@lmilbaum
Copy link
Author

Can this be done usingtox? So that these tests can be run locally instead of only being able to be done in the CI?

Doesn't have to be a default test that is run intox but would be good if it can be run locally.

Yup. I forgot to handle it via fox. Thanks for your feedback.

@lmilbaumlmilbaumforce-pushed theinstall branch 6 times, most recently from7e1e7d9 to5aa1690CompareNovember 21, 2022 22:36
@JohnVillalovos
Copy link
Member

@lmilbaum I probably won't have time to check this until next or the following week. Sorry. Holidays this week in the states and my work is keeping me busy too. I just wanted to let you know that I haven't forgotten.

@nejch Feel free to go ahead without me if it you like it. No need to wait for my approval.

lmilbaum reacted with thumbs up emoji

@lmilbaumlmilbaum requested a review fromnejchNovember 23, 2022 12:00
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for digging into this@lmilbaum, this took a bit longer than we all expected but will be useful later when we probably use it with some parametrized request clients :)

@nejchnejch merged commit0ecf3bb intopython-gitlab:mainNov 23, 2022
@lmilbaumlmilbaum deleted the install branchNovember 23, 2022 20:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lmilbaum@JohnVillalovos@nejch

[8]ページ先頭

©2009-2025 Movatter.jp