NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

docs(api): pushrules remove saying`None` is returned when not found#2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intomainfromjlvillal/push_rules

Nov 8, 2022

Merged

docs(api): pushrules remove saying`None` is returned when not found#2369

nejch merged 1 commit intomainfromjlvillal/push_rules

Nov 8, 2022

Conversation

Copy link

Member

JohnVillalovos commentedNov 8, 2022•
edited
Loading

Ingroups.pushrules.get(), GitLab does not returnNone when no rules are found. GitLab returns a 404.

Update docs to not say it will returnNone

Also update docs inproject.pushrules.get() to be consistent. Not
100% sure if it returnsNone or returns a 404, but we don't need to
document that.

Closes:#2368

JohnVillalovos requested a review fromnejch

November 8, 2022 15:41

nejch reviewed

Nov 8, 2022

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@JohnVillalovos, just a small question :)

docs/gl_objects/groups.rstShow resolvedHide resolved

docs(api): pushrules remove sayingNone is returned when not found

8c33c5b

In `groups.pushrules.get()`, GitLab does not return `None` when norules are found. GitLab returns a 404.Update docs to not say it will return `None`Also update docs in `project.pushrules.get()` to be consistent. Not100% sure if it returns `None` or returns a 404, but we don't need todocument that.Closes:#2368