Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add saml group links#2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 4 commits intopython-gitlab:mainfromabhishekmsingh:main
Nov 21, 2022
Merged

Conversation

abhishekmsingh
Copy link
Contributor

CLOSES#2270

@nejch
Copy link
Member

Just ping us here if you get stuck with anything @abhiandthetruth. Thanks for working on this!

@abhishekmsingh
Copy link
ContributorAuthor

@nejch occupied with some other work atm. Will try to complete soon

nejch reacted with heart emoji

@codecov-commenter
Copy link

codecov-commenter commentedNov 20, 2022•
edited
Loading

Codecov Report

Merging#2367 (3405a25) intomain (9d2b1ad) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #2367   +/-   ##=======================================  Coverage   95.96%   95.97%           =======================================  Files          80       80             Lines        5331     5342   +11     =======================================+ Hits         5116     5127   +11  Misses        215      215
FlagCoverage Δ
api_func_v483.73% <90.90%> (+0.03%)⬆️
cli_func_v482.38% <90.90%> (+0.01%)⬆️
unit87.75% <100.00%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/groups.py90.55% <100.00%> (+0.61%)⬆️

@abhishekmsinghabhishekmsingh marked this pull request as ready for reviewNovember 20, 2022 13:48
@abhishekmsingh
Copy link
ContributorAuthor

@nejch can you have a look?
Disabled functional tests since cant get them to work, getting 401 while creating a new saml group link. Might need to setup an identity provider in CI.

@abhishekmsinghabhishekmsingh requested review fromlmilbaum andnejch and removed request forlmilbaum andnejchNovember 20, 2022 15:36
@nejch
Copy link
Member

@nejch can you have a look? Disabled functional tests since cant get them to work, getting 401 while creating a new saml group link. Might need to setup an identity provider in CI.

note to self:

# https://docs.gitlab.com/ee/integration/omniauth.html#configure-initial-settings# https://docs.gitlab.com/ee/integration/saml.html#general-setupgitlab_rails['omniauth_allow_single_sign_on'] = ['saml']gitlab_rails['omniauth_block_auto_created_users'] = falsegitlab_rails['omniauth_providers'] = [  {    name: "saml",    args: {      assertion_consumer_service_url: "http://localhost:8080/users/auth/saml/callback",      idp_cert_fingerprint: "43:51:43:a1:b5:fc:8b:b7:0a:3a:a9:b1:0f:66:73:a8",      idp_sso_target_url: "https://login.example.com/idp",      issuer: "http://localhost:8080",      name_identifier_format: "urn:oasis:names:tc:SAML:2.0:nameid-format:persistent"    }  }]

Copy link
Member

@nejchnejch left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the work here @abhiandthetruth! The request body matcher in the unit tests will really help with confidence until we have a functional test setup for this.

I've squashed the commits here as the others weren't strictly for the changelog as afeat :)

abhishekmsingh reacted with thumbs up emoji
@nejchnejch merged commit1020ce9 intopython-gitlab:mainNov 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch approved these changes

+1 more reviewer

@lmilbaumlmilbaumlmilbaum left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for API Endpoint for SAML Group Sync

4 participants

@abhishekmsingh@nejch@codecov-commenter@lmilbaum
[8]ページ先頭
©2009-2025 Movatter.jp