- Notifications
You must be signed in to change notification settings - Fork673
Provide API wrapper for cherry picking commits#236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only 2 nitpicks, but the patch looks good. Could you make the minor changes and I'll merge.
Thank you!
docs/gl_objects/commits.rst Outdated
| @@ -43,6 +43,12 @@ Get the diff for a commit: | |||
| :start-after: # diff | |||
| :end-before: # end diff | |||
| Cherry-pick a commit into another branch | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please end the line with a colon (:) to introduce the example.
gitlab/objects.py Outdated
| GitlabCherryPickError: If the cherry pick could not be applied. | ||
| """ | ||
| url = '/projects/{0:s}/repository/commits/{1:s}/cherry_pick'.format( | ||
| self.project_id, self.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For the sake of consistency could you use the old%()s format? Yes, this is nitpicking :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I had problems with keeping the line length below the limit of 79 characters. I worked around it now by introducing another local variable with a short name. If you have any other suggestion on how to break this string across two lines, I'd be happy to hear.
Thank you for this patch! |
This is a possible implementation for addressing#235. It allows to cherry pick individual commits through the Gitlab API both from the python code as well as from the command line. The documentation has been updated.