Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add remote import s3#2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 2 commits intopython-gitlab:mainfromabhishekmsingh:main
Nov 2, 2022
Merged

Conversation

abhishekmsingh
Copy link
Contributor

Closes#2356

@abhishekmsingh
Copy link
ContributorAuthor

abhishekmsingh commentedNov 1, 2022
edited
Loading

@max-wittig@nejch can you review this PR please? Pretty similar to#2348
There is again a bit of replicated code from import_project function. Can't find a way to refactor it because it is quite small and creating any common entity just feals like overkill. Let me know if anyone has a way to go over it, else I think this much replication might be tolerable.

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great @abhiandthetruth thanks for the quick work again. Just a few quick notes :)

There is again a bit of replicated code from import_project function. Can't find a way to refactor it because it is quite small and creating any common entity just feals like overkill. Let me know if anyone has a way to go over it, else I think this much replication might be tolerable.

I agree, no need yet. We have plenty of other custom methods where this is an issue as well.

I think it would need a lot of rework but another decorator with required/optional payload attributes might make these methods more declarative instead of parsing args inside every method. Something like#1999 if we revive that at some point.

@abhishekmsingh
Copy link
ContributorAuthor

@nejch implemented the suggested changes.

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for this @abhiandthetruth, as you seem keen on contributing more later I added a small non-blocking note for a potential follow-up :) LGTM!

abhishekmsingh reacted with thumbs up emoji
@nejchnejch merged commit892281e intopython-gitlab:mainNov 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support from remote project import from S3

2 participants

@abhishekmsingh@nejch

[8]ページ先頭

©2009-2025 Movatter.jp