- Notifications
You must be signed in to change notification settings - Fork676
feat: add import project from remote support#2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
abhishekmsingh commentedOct 31, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nejch can you please have a look on this PR?
|
@abhiandthetruth that makes sense! Will check again in a bit, and sure you can go ahead with a separate issue. Yes, currently when we add custom methods it still means copying a bit of code, that needs some rework later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks again @abhiandthetruth, I had some minor nits but realized we can fix them later with other bits of code.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Yup will clean them up in the other PR. Thanks! Waiting for my first merge in the repo! |
resolves#2260