Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: pre-commit triggered from tox#2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:mainfromlmilbaum:refactoring
Oct 20, 2022

Conversation

@lmilbaum
Copy link

@lmilbaumlmilbaum commentedOct 17, 2022•
edited
Loading

The project is using two liniting frameworks: tox and pre-commit. Each has its own configuration files and a CI workflow.
The purpose of this PR is to consolidate linting into one framework: tox
Discussion -#2321

This PR is a baby step towards a full transition

@JohnVillalovos
Copy link
Member

I personally don't like this as I do NOT use pre-commit. I like to do everything in tox. And I do not want to use pre-commit.

@lmilbaumlmilbaumforce-pushed therefactoring branch 3 times, most recently fromb6f5bf3 todd7730eCompareOctober 17, 2022 05:08
@lmilbaum
Copy link
Author

I personally don't like this as I do NOT use pre-commit. I like to do everything in tox. And I do not want to use pre-commit.

Good point. I should have raised this topic in a discussion.

@lmilbaumlmilbaumforce-pushed therefactoring branch 9 times, most recently from29cafad toca5b6a7CompareOctober 19, 2022 10:57
@lmilbaumlmilbaum changed the titlerefactor: lint duplications in tox and pre-commitrefactor: pre-commit trigger from toxOct 19, 2022
@lmilbaumlmilbaumforce-pushed therefactoring branch 2 times, most recently from0042e7a to214c2d7CompareOctober 19, 2022 11:12
@lmilbaumlmilbaum requested a review fromnejchOctober 19, 2022 11:16
@lmilbaumlmilbaum marked this pull request as ready for reviewOctober 19, 2022 11:31
@lmilbaumlmilbaum changed the titlerefactor: pre-commit trigger from toxrefactor: pre-commit triggered from toxOct 19, 2022
@lmilbaumlmilbaum marked this pull request as ready for reviewOctober 19, 2022 18:06
@lmilbaumlmilbaum requested a review fromnejchOctober 19, 2022 18:06
Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This works for me. As I usually run a subset of the tox checks in my development process.

I like that I don't have to runpre-commit and can just usetox 🙂

So I approve but let@nejch do the merging if he approves.

lmilbaum reacted with thumbs up emoji
@nejch
Copy link
Member

time tox gives me 50s versus 20s before so running the default env list takes a bit long now, but let's get this in and work on that later :)

@nejchnejch merged commiteec6c02 intopython-gitlab:mainOct 20, 2022
@lmilbaumlmilbaum deleted the refactoring branchOctober 20, 2022 07:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

@nejchnejchAwaiting requested review from nejch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmilbaum@JohnVillalovos@nejch
[8]ページ先頭
©2009-2025 Movatter.jp