Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Changelog: improve Changelog & convert to Markdown#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpocentek merged 1 commit intopython-gitlab:masterfromGhostLyrics:master
Mar 9, 2017
Merged

Changelog: improve Changelog & convert to Markdown#230

gpocentek merged 1 commit intopython-gitlab:masterfromGhostLyrics:master
Mar 9, 2017

Conversation

GhostLyrics
Copy link
Contributor

I hope that you like what I did to the Changelog and are not offended I chose not to use RST for this, but the comparison links didn't seem well suited for what I could find about RST's link syntax.

  • rename to ChangeLog.markdown
  • add release dates
  • add comparison links

Fixes#229

@gpocentek
Copy link
Contributor

Thank you, this is a great improvement! A few comments:

  • Could you switch to RST? Everything else is RST, and it would allow us to add the changelog in the docs
  • Could you also amend you commit to fix the pep8 issue? Make the short commit message shorter, and add information in the commit message body.

Thanks!

@GhostLyrics
Copy link
ContributorAuthor

Can you use variables for links in Rest like I used for the changes? See the bottom of the file. All this would need to be inline unless I overlooked something.

@gpocentek
Copy link
Contributor

Yes, you can use something like:

Version 0.19_: * blah blah blah.. _0.19: http://whatever.com

http://docutils.sourceforge.net/docs/user/rst/quickref.html#hyperlink-targets

@GhostLyrics
Copy link
ContributorAuthor

Will try to do this today.

+ change indentation so bullet points are not treated as quote+ add links to releases+ add dates to releases+ use releases as headers
@GhostLyrics
Copy link
ContributorAuthor

It's done and the tests pass :)

@gpocentek
Copy link
Contributor

Looks good, thank you!

@gpocentekgpocentek merged commit37ee7ea intopython-gitlab:masterMar 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@GhostLyrics@gpocentek

[8]ページ先頭

©2009-2025 Movatter.jp