- Notifications
You must be signed in to change notification settings - Fork674
fix(cli): handle list response for json/yaml output#2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
46b091f toe8b18a5Comparecodecov-commenter commentedSep 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #2290 +/- ##==========================================+ Coverage 95.29% 95.31% +0.01%========================================== Files 79 79 Lines 5246 5246 ==========================================+ Hits 4999 5000 +1+ Misses 247 246 -1
Flags with carried forward coverage won't be shown.Click here to find out more.
|
6500602 toe4409caCompare
nejch left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice fix@JohnVillalovos! Just a quick question on tests as I'm seeing some more repetition now the sidekiq handling.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
e4409ca tocd9695dCompareHandle the case with the CLI where a list response is returned fromGitLab and json/yaml output is requested.Add a functional CLI test to validate it works.Closes:#2287
cd9695d tofbc0ecbCompare
Handle the case with the CLI where a list response is returned from GitLab and json/yaml output is requested.
Closes:#2287