Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for deployment approval endpoint#2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/deploy_approve
Aug 28, 2022

Conversation

JohnVillalovos
Copy link
Member

Add support for the deployment approval endpoint[1]

[1]https://docs.gitlab.com/ee/api/deployments.html#approve-or-reject-a-blocked-deployment
Closes:#2253

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks LGTM! Just a quick question mostly about upstream API weirdness.

@codecov-commenter
Copy link

Codecov Report

Merging#2254 (9c9eeb9) intomain (e095735) willincrease coverage by8.18%.
The diff coverage is87.50%.

@@            Coverage Diff             @@##             main    #2254      +/-   ##==========================================+ Coverage   87.23%   95.41%   +8.18%==========================================  Files          81       81                Lines        5375     5390      +15     ==========================================+ Hits         4689     5143     +454+ Misses        686      247     -439
FlagCoverage Δ
api_func_v481.29% <50.00%> (?)
cli_func_v482.83% <50.00%> (?)
unit87.23% <87.50%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/deployments.py93.10% <85.71%> (-6.90%)⬇️
gitlab/exceptions.py100.00% <100.00%> (ø)
gitlab/config.py100.00% <0.00%> (+1.12%)⬆️
gitlab/utils.py98.59% <0.00%> (+1.40%)⬆️
gitlab/v4/objects/members.py94.82% <0.00%> (+1.72%)⬆️
gitlab/v4/objects/export_import.py94.73% <0.00%> (+2.63%)⬆️
gitlab/types.py98.21% <0.00%> (+3.57%)⬆️
gitlab/v4/objects/notes.py94.28% <0.00%> (+3.80%)⬆️
gitlab/v4/objects/groups.py89.40% <0.00%> (+3.97%)⬆️
gitlab/v4/objects/jobs.py78.26% <0.00%> (+4.34%)⬆️
... and31 more

@nejchnejch merged commit56fbe02 intomainAug 28, 2022
@nejchnejch deleted the jlvillal/deploy_approve branchAugust 28, 2022 20:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE: Support deployment approve/reject
3 participants
@JohnVillalovos@codecov-commenter@nejch

[8]ページ先頭

©2009-2025 Movatter.jp