Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(client): warn user on misconfigured URL inauth()#2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 3 commits intomainfromfeat/warn-user-misconfigured-url
Aug 4, 2022

Conversation

nejch
Copy link
Member

@nejchnejch commentedAug 4, 2022•
edited
Loading

Closes#1978.

3 steps here:

  • 7b61ae6 removes a hack to handle gitlab's non-standard headers. That was only valid for 13.0 and fixed in 13.1 - super old now and I wouldn't say we're expected to support that.
  • 31c9c2f refactors the nested code out into a slightly more generic helper (that's where it should live anyway, as most of the attributes are from the Gitlab instance)
  • d71c1db adds it toauth() so the user gets a warning ASAP.

Other than that I haven't changed any of thestr/None handling to keep thenext_url code the same in_query.

@nejchnejchforce-pushed thefeat/warn-user-misconfigured-url branch from6f5b0e7 tod71c1dbCompareAugust 4, 2022 16:21
@nejchnejch marked this pull request as ready for reviewAugust 4, 2022 16:22
Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Thanks@nejch

@JohnVillalovosJohnVillalovos merged commit0040b43 intomainAug 4, 2022
@JohnVillalovosJohnVillalovos deleted the feat/warn-user-misconfigured-url branchAugust 4, 2022 16:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn user when detecting misconfigured serverexternal_url?
2 participants
@nejch@JohnVillalovos
[8]ページ先頭
©2009-2025 Movatter.jp