Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Time tracking#222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpocentek merged 7 commits intopython-gitlab:masterfromsavenger:time_tracking
Mar 3, 2017
Merged

Conversation

savenger
Copy link
Contributor

@savengersavenger commentedFeb 16, 2017
edited
Loading

This adds support for gitlabs time tracking feature#221

DmytroLitvinov reacted with thumbs up emoji
Sascha Mahmood added2 commitsFebruary 15, 2017 16:05
- get/set/remove estimated time per issue- get/set/remove time spent per issu
@GhostLyrics
Copy link
Contributor

The automated build failed. Please fix :)

@gpocentek
Copy link
Contributor

Thank you. Could you squash your commits in a single one? Thanks.

@GhostLyrics
Copy link
Contributor

@gpocentek you can do that from the merge interface toohttps://github.com/blog/2243-rebase-and-merge-pull-requests

@gpocentek
Copy link
Contributor

Ah nice! Never used this before, thanks@GhostLyrics

@gpocentekgpocentek merged commit92151b2 intopython-gitlab:masterMar 3, 2017
@savengersavenger deleted the time_tracking branchMarch 3, 2017 13:24
@DmytroLitvinov
Copy link

DmytroLitvinov commentedMar 20, 2017
edited
Loading

@gpocentek Hi. Cool feature was added, but it`s not documented.http://python-gitlab.readthedocs.io/en/stable/gl_objects/issues.html. But as I seehere you added documentation.

@gpocentek
Copy link
Contributor

@DmytroLitvinov the documentation is available athttp://python-gitlab.readthedocs.io/en/latest/gl_objects/issues.html (latest instead of stable). It will switch to stable once I release the version containing this change (soonish).

Thank you for checking!

@DmytroLitvinov
Copy link

DmytroLitvinov commentedMar 20, 2017
edited
Loading

@gpocentek It will in version 0.20 of this library, right? If yes, could you specify the release date, please.

@savenger
Copy link
ContributorAuthor

I just saw that the documentation was not committed correctly. Should I open a new issue or re-open the issue? Or just open a new pull request?

@DmytroLitvinov
Copy link

DmytroLitvinov commentedMar 20, 2017
edited
Loading

@savenger Is it work correctly? I have an error.

Traceback (most recent call last):  File "gtest.py", line 24, in <module>    issue.reset_time_spent()  File "/home/dmytro/.virtualenvs/GetMyHours/src/python-gitlab/gitlab/objects.py", line 432, in __getattr__    raise AttributeErrorAttributeError

It is methodreset_spent_time at issue instance. Notreset_time_spent.
https://github.com/gpocentek/python-gitlab/blob/master/gitlab/objects.py#L1584

Also

Traceback (most recent call last):  File "gtest.py", line 25, in <module>    issue.time_estimate({'duration': '3h30m'})TypeError: time_estimate() takes exactly 1 argument (2 given)

@DmytroLitvinov
Copy link

DmytroLitvinov commentedMar 20, 2017
edited
Loading

Also it is replaced logic in functions:
https://github.com/gpocentek/python-gitlab/blob/master/gitlab/objects.py#L1584
and herehttps://github.com/gpocentek/python-gitlab/blob/master/gitlab/objects.py#L1597 in variableurl . Atadd_spent_time you reset spent time and inreset_spent_time you add time.

@gpocentek
Copy link
Contributor

@DmytroLitvinov yes it will be in 0.20. I'm not sure about the release date, waiting on a couple changes. It shouldn't be long though (end of week, or next week maybe).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@savenger@GhostLyrics@gpocentek@DmytroLitvinov

[8]ページ先頭

©2009-2025 Movatter.jp