- Notifications
You must be signed in to change notification settings - Fork673
chore: remove broad Exception catching fromconfig.py
#2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
28d51f8
to1471c82
CompareThanks@JohnVillalovos! Just 2 questions. FWIW I recently realized we are rolling our own homebrew version of configparser (with all this try/except spaghetti) when python3's (and previously But probably not worth migrating that breaking change now that tomllib is coming to the stdlib and might be more attractivein the future to bring the config format in line with trends in the python world. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
1471c82
tob70a438
Comparecodecov-commenter commentedAug 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #2212 +/- ##==========================================- Coverage 95.43% 95.43% -0.01%========================================== Files 81 81 Lines 5369 5368 -1 ==========================================- Hits 5124 5123 -1 Misses 245 245
Flags with carried forward coverage won't be shown.Click here to find out more.
|
b70a438
to17dc79d
CompareChange "except Exception:" catching to more granular exceptions.A step in enabling the "broad-except" check in pylint.
17dc79d
to0abc90b
CompareCool, I think we can get this in and double check if any new errors are thrown before the 28th :) |
Change "except Exception:" catching to more granular exceptions.
A step in enabling the "broad-except" check in pylint.