Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove broad Exception catching fromconfig.py#2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/config
Aug 7, 2022

Conversation

JohnVillalovos
Copy link
Member

Change "except Exception:" catching to more granular exceptions.

A step in enabling the "broad-except" check in pylint.

@JohnVillalovosJohnVillalovos marked this pull request as draftAugust 2, 2022 05:45
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewAugust 2, 2022 06:27
@nejch
Copy link
Member

Thanks@JohnVillalovos! Just 2 questions.

FWIW I recently realized we are rolling our own homebrew version of configparser (with all this try/except spaghetti) when python3's (and previouslySafeConfigParser) parser actually handles section- vs.default defined options natively.

But probably not worth migrating that breaking change now that tomllib is coming to the stdlib and might be more attractivein the future to bring the config format in line with trends in the python world.

@codecov-commenter
Copy link

codecov-commenter commentedAug 4, 2022
edited
Loading

Codecov Report

Merging#2212 (0abc90b) intomain (9aecc9e) willdecrease coverage by0.00%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #2212      +/-   ##==========================================- Coverage   95.43%   95.43%   -0.01%==========================================  Files          81       81                Lines        5369     5368       -1     ==========================================- Hits         5124     5123       -1  Misses        245      245
FlagCoverage Δ
api_func_v481.35% <75.00%> (+0.03%)⬆️
cli_func_v482.97% <90.00%> (-0.08%)⬇️
unit87.27% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/config.py100.00% <100.00%> (ø)

Change "except Exception:" catching to more granular exceptions.A step in enabling the "broad-except" check in pylint.
@nejch
Copy link
Member

Cool, I think we can get this in and double check if any new errors are thrown before the 28th :)

@nejchnejch merged commit70e67bf intomainAug 7, 2022
@nejchnejch deleted the jlvillal/config branchAugust 7, 2022 09:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@nejch@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp