NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

chore: make code PEP597 compliant#2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intomainfromjlvillal/encoding_warning

Jul 29, 2022

Merged

chore: make code PEP597 compliant#2201

nejch merged 1 commit intomainfromjlvillal/encoding_warning

Jul 29, 2022

Conversation

Copy link

Member

JohnVillalovos commentedJul 29, 2022

Useencoding="utf-8" inopen() and open-like functions.

https://peps.python.org/pep-0597/

chore: make code PEP597 compliant

433dba0

Use `encoding="utf-8"` in `open()` and open-like functions.https://peps.python.org/pep-0597/

Copy link

codecov-commenter commentedJul 29, 2022

Codecov Report

Merging#2201 (433dba0) intomain (8ba97aa) willincrease coverage by4.00%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #2201      +/-   ##==========================================+ Coverage   91.56%   95.56%   +4.00%==========================================  Files          81       81                Lines        5344     5344              ==========================================+ Hits         4893     5107     +214+ Misses        451      237     -214

Flag	Coverage Δ
api_func_v4	`81.41% <100.00%> (?)`
cli_func_v4	`83.06% <100.00%> (-0.10%)`	⬇️
unit	`87.31% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/config.py	`100.00% <100.00%> (ø)`
gitlab/utils.py	`98.59% <0.00%> (+1.40%)`	⬆️
gitlab/v4/objects/members.py	`94.82% <0.00%> (+1.72%)`	⬆️
gitlab/client.py	`98.70% <0.00%> (+3.44%)`	⬆️
gitlab/types.py	`98.21% <0.00%> (+3.57%)`	⬆️
gitlab/v4/objects/notes.py	`94.28% <0.00%> (+3.80%)`	⬆️
gitlab/v4/objects/groups.py	`89.40% <0.00%> (+3.97%)`	⬆️
gitlab/v4/objects/pages.py	`100.00% <0.00%> (+5.00%)`	⬆️
gitlab/v4/objects/events.py	`98.73% <0.00%> (+5.06%)`	⬆️
gitlab/mixins.py	`92.30% <0.00%> (+5.49%)`	⬆️
... and22 more

Copy link

Member

nejch commentedJul 29, 2022

Thanks@JohnVillalovos!

Slightly related to this, I've seen some linters suggest to always use the standardwith open() ... as f: pattern as suggested inhttps://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files, to avoid arbitrary file descriptor names and shadowingfile. Also discourages creating nested managers I assume. But I can't find an example now.