Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: support array types for most resources#2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 3 commits intomainfromfix/array-attributes
Jul 28, 2022

Conversation

nejch
Copy link
Member

@nejchnejch commentedJul 28, 2022•
edited
Loading

Closes#780.

I skippedarray of hashes and I didn't touch some endpoints like merge requests that I think need another look at this topic (merge requests in particular). It's already a chunky PR, so I split it into fix/test/docs commits.

@nejchnejch marked this pull request as ready for reviewJuly 28, 2022 11:34
@nejchnejchforce-pushed thefix/array-attributes branch from44970c9 toe740cfaCompareJuly 28, 2022 11:34
@codecov-commenter
Copy link

Codecov Report

Merging#2196 (44970c9) intomain (510ec30) willincrease coverage by0.01%.
The diff coverage is100.00%.

❗ Current head44970c9 differs from pull request most recent heade740cfa. Consider uploading reports for the commite740cfa to get more accurate results

@@            Coverage Diff             @@##             main    #2196      +/-   ##==========================================+ Coverage   95.53%   95.55%   +0.01%==========================================  Files          81       81                Lines        5309     5331      +22     ==========================================+ Hits         5072     5094      +22  Misses        237      237
FlagCoverage Δ
api_func_v481.56% <100.00%> (+0.07%)⬆️
cli_func_v483.11% <100.00%> (+0.29%)⬆️
unit87.33% <100.00%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/projects.py100.00% <ø> (ø)
gitlab/v4/objects/broadcast_messages.py100.00% <100.00%> (ø)
gitlab/v4/objects/deploy_tokens.py100.00% <100.00%> (ø)
gitlab/v4/objects/environments.py100.00% <100.00%> (ø)
gitlab/v4/objects/group_access_tokens.py100.00% <100.00%> (ø)
gitlab/v4/objects/invitations.py100.00% <100.00%> (ø)
gitlab/v4/objects/jobs.py78.26% <100.00%> (+0.64%)⬆️
gitlab/v4/objects/members.py94.82% <100.00%> (ø)
gitlab/v4/objects/personal_access_tokens.py100.00% <100.00%> (ø)
gitlab/v4/objects/project_access_tokens.py100.00% <100.00%> (ø)
... and3 more

Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wow! That looks like it took a lot of time to go through all the docs!! Thanks.

Left comments on two things I saw.

Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@nejch

@JohnVillalovosJohnVillalovosenabled auto-merge (rebase)July 28, 2022 14:33
@JohnVillalovosJohnVillalovos merged commit4a6f8d6 intomainJul 28, 2022
@JohnVillalovosJohnVillalovos deleted the fix/array-attributes branchJuly 28, 2022 14:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create impersonation token from CLI
3 participants
@nejch@codecov-commenter@JohnVillalovos
[8]ページ先頭
©2009-2025 Movatter.jp