- Notifications
You must be signed in to change notification settings - Fork673
test(functional): bump GitLab docker image to 15.2.0-ee.0#2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Use the GitLab docker image 15.2.0-ee.0 in the functional testing.
Uh oh!
There was an error while loading.Please reload this page.
f1603e2 to3e07453Comparecodecov-commenter commentedJul 28, 2022
Codecov Report
@@ Coverage Diff @@## main #2194 +/- ##==========================================- Coverage 95.54% 95.49% -0.06%========================================== Files 81 81 Lines 5296 5344 +48 ==========================================+ Hits 5060 5103 +43- Misses 236 241 +5
Flags with carried forward coverage won't be shown.Click here to find out more.
|
3e07453 toaf47e74CompareIn GitLab >= 15.0 `title` is required when creating a topic.
Cluster support was deprecated in GitLab 14.5 [1]. And disabled bydefault in GitLab 15.0 [2] * Update docs to mark clusters as deprecated * Remove testing of clusters[1]https://docs.gitlab.com/ee/api/project_clusters.html[2]https://gitlab.com/groups/gitlab-org/configure/-/epics/8
af47e74 tob46b379Compare| create_dict = {"name": "my-topic", "description": "My Topic"} | ||
| if gitlab_version.major >= 15: | ||
| create_dict["title"] = "my topic title" | ||
| topic = gl.topics.create( | ||
| {"name": "my-topic", "title": "my topic title", "description": "My Topic"} | ||
| ) | ||
| assert topic.name == "my-topic" | ||
| if gitlab_version.major >= 15: | ||
| assert topic.title == "my topic title" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FWIW I don't think we need to test multiple major versions as tests get complicated quickly, but I agree it'll be helpful having version checks when developing new features.
Use the GitLab docker image 15.2.0-ee.0 in the functional testing.