NotificationsYou must be signed in to change notification settings
Fork675
Star2.4k

test: always ensure clean config environment#2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JohnVillalovos merged 1 commit intomainfromtest/clean-config

Jul 26, 2022

Merged

test: always ensure clean config environment#2187

JohnVillalovos merged 1 commit intomainfromtest/clean-config

Jul 26, 2022

Conversation

Copy link

Member

nejch commentedJul 26, 2022

Closes#2177

nejch commented

Jul 26, 2022

View reviewed changes

tests/conftest.pyShow resolvedHide resolved

JohnVillalovos reviewed

Jul 26, 2022

View reviewed changes

Copy link

Member

JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this!

Left one question for something I didn't understand.

tests/unit/test_config.pyShow resolvedHide resolved

nejch force-pushed thetest/clean-config branch from3327cb6 to7b5a282Compare

July 26, 2022 14:40

test: always ensure clean config environment

920c443

nejch force-pushed thetest/clean-config branch from2070d5f to920c443Compare

July 26, 2022 16:56

Copy link

codecov-commenter commentedJul 26, 2022

Codecov Report

Merging#2187 (920c443) intomain (4b798fc) willincrease coverage by4.04%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #2187      +/-   ##==========================================+ Coverage   91.47%   95.52%   +4.04%==========================================  Files          80       80                Lines        5268     5268              ==========================================+ Hits         4819     5032     +213+ Misses        449      236     -213

Flag	Coverage Δ
api_func_v4	`81.37% <ø> (?)`
cli_func_v4	`83.02% <ø> (ø)`
unit	`87.22% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/utils.py	`100.00% <0.00%> (+1.61%)`	⬆️
gitlab/v4/objects/members.py	`94.82% <0.00%> (+1.72%)`	⬆️
gitlab/types.py	`98.07% <0.00%> (+1.92%)`	⬆️
gitlab/client.py	`98.70% <0.00%> (+3.44%)`	⬆️
gitlab/v4/objects/notes.py	`94.28% <0.00%> (+3.80%)`	⬆️
gitlab/v4/objects/groups.py	`89.18% <0.00%> (+4.05%)`	⬆️
gitlab/v4/objects/pages.py	`100.00% <0.00%> (+5.00%)`	⬆️
gitlab/v4/objects/events.py	`98.73% <0.00%> (+5.06%)`	⬆️
gitlab/mixins.py	`92.30% <0.00%> (+5.49%)`	⬆️
gitlab/v4/objects/users.py	`96.38% <0.00%> (+6.02%)`	⬆️
... and21 more