- Notifications
You must be signed in to change notification settings - Fork673
fix(runners): fix listing for /runners/all#2167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedJul 23, 2022
Codecov Report
@@ Coverage Diff @@## main #2167 +/- ##======================================= Coverage 95.40% 95.41% ======================================= Files 79 79 Lines 5181 5191 +10 =======================================+ Hits 4943 4953 +10 Misses 238 238
Flags with carried forward coverage won't be shown.Click here to find out more.
|
JohnVillalovos approved these changesJul 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Makes listing all runners (admin endpoint) possible via the CLI and fixes arguments that were being ignored in
runners.all()by reusing our standardlist()from the mixin instead. I haven't deprecated yet to give people time to change before warnings start to emit.Closes#593
Replaces#2115