Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update type-hints#2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JohnVillalovos wants to merge4 commits intomain
base:main
Choose a base branch
Loading
fromjlvillal/find_non_dict
Draft

Conversation

JohnVillalovos
Copy link
Member

chore: correct type-hints forparticipants() method

Theparticipants() method returns a list of dictionaries. Update the
type-hints for it.

chore: correct type-hints forhttp_get/http_post derived values

The methodshttp_get() andhttp_post() can also return alist.
Update the code to handle that case.

Closes:#2158

@JohnVillalovosJohnVillalovos marked this pull request as draftJuly 21, 2022 04:21
@codecov-commenter
Copy link

codecov-commenter commentedJul 21, 2022•
edited by codecovbot
Loading

Codecov Report

Attention: Patch coverage is96.42857% with2 lines in your changes missing coverage. Please review.

Project coverage is 95.40%. Comparing base(9833632) to head(00b3e26).
Report is 778 commits behind head on main.

Files with missing linesPatch %Lines
gitlab/mixins.py50.00%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2159      +/-   ##==========================================- Coverage   95.42%   95.40%   -0.02%==========================================  Files          79       79                Lines        5198     5206       +8     ==========================================+ Hits         4960     4967       +7- Misses        238      239       +1
FlagCoverage Δ
api_func_v481.29% <91.07%> (-0.03%)⬇️
cli_func_v482.75% <83.92%> (-0.04%)⬇️
unit87.11% <96.42%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/base.py99.51% <100.00%> (+<0.01%)⬆️
gitlab/cli.py100.00% <100.00%> (ø)
gitlab/client.py98.72% <100.00%> (+0.01%)⬆️
gitlab/v4/objects/commits.py94.80% <100.00%> (-0.07%)⬇️
gitlab/v4/objects/deploy_keys.py96.42% <100.00%> (ø)
gitlab/v4/objects/environments.py100.00% <100.00%> (ø)
gitlab/v4/objects/groups.py88.96% <ø> (-0.08%)⬇️
gitlab/v4/objects/merge_requests.py84.78% <100.00%> (-0.11%)⬇️
gitlab/v4/objects/pipelines.py94.44% <100.00%> (ø)
gitlab/v4/objects/projects.py100.00% <100.00%> (ø)
... and4 more
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/find_non_dict branch 9 times, most recently frombf02f9e tod4c2b57CompareJuly 23, 2022 07:10
Update code so that the `warn_return_any` check passes.
The methods `http_get()` and `http_post()` can also return a `list`.Update the code to handle that case.Closes:#2158
The `participants()` method returns a list of dictionaries. Update thetype-hints for it.
The functions return Optional[bool].Add tests for their behavior
@github-actionsGitHub Actions
Copy link

This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days.

@github-actionsgithub-actionsbot added stale and removed stale labelsJul 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to update type annotations for http_* methods
2 participants
@JohnVillalovos@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp