- Notifications
You must be signed in to change notification settings - Fork673
fix: don't ignore 'as_list=False' for getting runners as iterator#2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The `gitlab.runners.all(as_list=False)` was ignoring the flag, returning a list regardless
Thanks for your contribution@koreno! I think we could get this in, but ideally we would get rid of the custom We did exactly the same for the That would actually fix#593 as well. |
I'm gonna have to let you take over from here, I can't really afford to dig in much further... |
Thanks again@koreno, I've opened#2167 to reuse our existing Should be released on the 28th. |
The
gitlab.runners.all(as_list=False)
was ignoring the flag, returning a list regardless