Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: don't ignore 'as_list=False' for getting runners as iterator#2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

koreno
Copy link

Thegitlab.runners.all(as_list=False) was ignoring the flag, returning a list regardless

nejch reacted with thumbs up emoji
The `gitlab.runners.all(as_list=False)` was ignoring the flag, returning a list regardless
@nejch
Copy link
Member

Thanks for your contribution@koreno!

I think we could get this in, but ideally we would get rid of the customall() methods and convert therunners/all into a proper manager so we can userunners_all.list(iterator=True) directly using theListMixin.

We did exactly the same for themembers/all endpoint and deprecatedall():#1376, so we already have some precedent on how to do it (just ignore theAllMixin changes there, not relevant here).
I've wanted to do this for a while. Would you be interested in reworking the PR for that? Otherwise we'll start with a minimal change and follow-up.

That would actually fix#593 as well.

@koreno
Copy link
Author

I'm gonna have to let you take over from here, I can't really afford to dig in much further...

@korenokoreno removed their assignmentJul 3, 2022
@nejchnejch self-assigned thisJul 3, 2022
@nejch
Copy link
Member

I'm gonna have to let you take over from here, I can't really afford to dig in much further...

Thanks for your work on this@koreno. to avoid double work (e.g. getting your initial fix in and then tackling#593), I'll get to this ASAP.

@nejch
Copy link
Member

Thanks again@koreno, I've opened#2167 to reuse our existinglist() infrastructure and fix a related issue, replacing the custom method used here. Note that the newrunners_all.list() will behave slightly differently, you'll still need toget() individual runners to get more details or manipulate them.

Should be released on the 28th.

@nejchnejch closed thisJul 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@nejchnejch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@koreno@nejch@JohnVillalovos

[8]ページ先頭

©2009-2025 Movatter.jp