NotificationsYou must be signed in to change notification settings
Fork674
Star2.4k

test(pylint): enable pylint "unused-argument" check#2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intomainfromjlvillal/pylint_2022-06-26

Jun 27, 2022

Merged

test(pylint): enable pylint "unused-argument" check#2100

nejch merged 1 commit intomainfromjlvillal/pylint_2022-06-26

Jun 27, 2022

Conversation

Copy link

Member

JohnVillalovos commentedJun 26, 2022

Enable the pylint "unused-argument" check and resolve issues it found.

Quite a few functions were accepting**kwargs but not then
passing them on through to the next level. Now pass**kwargs to
next level.
Other functions had no reason to accept**kwargs, so remove it
And a few other fixes.

Copy link

codecov-commenter commentedJun 26, 2022•
edited
Loading

Codecov Report

Merging#2100 (23feae9) intomain (b644721) willnot change coverage.
The diff coverage is66.66%.

@@           Coverage Diff           @@##             main    #2100   +/-   ##=======================================  Coverage   94.73%   94.73%           =======================================  Files          78       78             Lines        5087     5087           =======================================  Hits         4819     4819             Misses        268      268

Flag	Coverage Δ
cli_func_v4	`82.42% <33.33%> (ø)`
py_func_v4	`81.14% <13.33%> (ø)`
unit	`85.80% <60.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/client.py	`98.68% <ø> (ø)`
gitlab/v4/objects/groups.py	`88.73% <0.00%> (ø)`
gitlab/v4/objects/jobs.py	`77.27% <33.33%> (ø)`
gitlab/v4/cli.py	`90.61% <100.00%> (ø)`
gitlab/v4/objects/merge_request_approvals.py	`90.80% <100.00%> (ø)`
gitlab/v4/objects/pipelines.py	`94.44% <100.00%> (ø)`
gitlab/v4/objects/projects.py	`90.00% <100.00%> (ø)`
gitlab/v4/objects/services.py	`100.00% <100.00%> (ø)`

nejch requested changes

Jun 26, 2022

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@JohnVillalovos, just a few tiny comments mainly for always passing onkwargs as we claim in our docs that we support it forsudo (and maybe in a few cases would also be useful for pagination args).

gitlab/v4/objects/merge_request_approvals.pyShow resolvedHide resolved

gitlab/v4/objects/services.pyShow resolvedHide resolved

gitlab/v4/cli.py OutdatedShow resolvedHide resolved

test(pylint): enable pylint "unused-argument" check

23feae9

Enable the pylint "unused-argument" check and resolve issues it found.  * Quite a few functions were accepting `**kwargs` but not then    passing them on through to the next level. Now pass `**kwargs` to    next level.  * Other functions had no reason to accept `**kwargs`, so remove it  * And a few other fixes.