- Notifications
You must be signed in to change notification settings - Fork673
chore: add the version of python-gitlab to GitlabError#2093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks@JohnVillalovos! This is a specific implementation for one exception. If we do this, a more generic approach might be useful I think, otherwise we might have to litter our code with custom exception messages. But I'm also not sure if exception messages are the right place for this. Did you get this idea from existing libraries? I think we should look into#2080, maybe in combination with exception hooks if we want this 🤔 not sure, it just seems more like a logging topic IMO? |
Good idea. Let me explore having it in the base GitlabExeception class. But probably not today... |
People will post tracebacks of exceptions but not post information onthe version of python-gitlab used.Add the version of python-gitlab to the GitlabError exception message.
f6028e6
to7577c91
Comparecodecov-commenter commentedJun 25, 2022 • edited by codecovbot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by codecovbot
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #2093 +/- ##======================================= Coverage 94.72% 94.73% ======================================= Files 78 78 Lines 5083 5088 +5 =======================================+ Hits 4815 4820 +5 Misses 268 268
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
I would also look athttps://stackoverflow.com/questions/5191830/how-do-i-log-a-python-error-with-debug-information as a clean option. Of course, we'd need a nicer setup for#2080 first. |
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
Uh oh!
There was an error while loading.Please reload this page.
People will post tracebacks of exceptions but not post information on
the version of python-gitlab used.
Add the version of python-gitlab to the GitlabError exception message.