Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add the version of python-gitlab to GitlabError#2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JohnVillalovos wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromjlvillal/version_in_keyerror

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedJun 25, 2022
edited
Loading

People will post tracebacks of exceptions but not post information on
the version of python-gitlab used.

Add the version of python-gitlab to the GitlabError exception message.

@nejch
Copy link
Member

Thanks@JohnVillalovos! This is a specific implementation for one exception. If we do this, a more generic approach might be useful I think, otherwise we might have to litter our code with custom exception messages.

But I'm also not sure if exception messages are the right place for this. Did you get this idea from existing libraries? I think we should look into#2080, maybe in combination with exception hooks if we want this 🤔 not sure, it just seems more like a logging topic IMO?

@JohnVillalovosJohnVillalovos marked this pull request as draftJune 25, 2022 16:30
@JohnVillalovos
Copy link
MemberAuthor

Good idea. Let me explore having it in the base GitlabExeception class. But probably not today...

People will post tracebacks of exceptions but not post information onthe version of python-gitlab used.Add the version of python-gitlab to the GitlabError exception message.
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/version_in_keyerror branch fromf6028e6 to7577c91CompareJune 25, 2022 17:04
@codecov-commenter
Copy link

codecov-commenter commentedJun 25, 2022
edited by codecovbot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base(f9b7c7b) to head(7577c91).
Report is 869 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #2093   +/-   ##=======================================  Coverage   94.72%   94.73%           =======================================  Files          78       78             Lines        5083     5088    +5     =======================================+ Hits         4815     4820    +5  Misses        268      268
FlagCoverage Δ
cli_func_v482.42% <80.00%> (-0.01%)⬇️
py_func_v481.19% <100.00%> (+0.01%)⬆️
unit85.84% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/exceptions.py100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovosJohnVillalovos changed the titlechore: add the version of python-gitlab to Exceptionchore: add the version of python-gitlab to GitlabErrorJun 26, 2022
@nejch
Copy link
Member

Good idea. Let me explore having it in the base GitlabExeception class. But probably not today...

I would also look athttps://stackoverflow.com/questions/5191830/how-do-i-log-a-python-error-with-debug-information as a clean option. Of course, we'd need a nicer setup for#2080 first.

@github-actionsGitHub Actions
Copy link

This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days.

@github-actionsgithub-actionsbot added stale and removed stale labelsJul 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@nejch@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp