Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add alazy boolean attribute toRESTObject#2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/mark_lazy_state
Jul 20, 2022

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedJun 20, 2022•
edited
Loading

This can be used to tell if aRESTObject was created using
lazy=True.

Add a message to theAttributeError if attribute access fails for an
instance created withlazy=True.

@codecov-commenter
Copy link

codecov-commenter commentedJun 20, 2022•
edited
Loading

Codecov Report

Merging#2082 (8d8f296) intomain (e772248) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #2082   +/-   ##=======================================  Coverage   95.39%   95.39%           =======================================  Files          79       79             Lines        5149     5152    +3     =======================================+ Hits         4912     4915    +3  Misses        237      237
FlagCoverage Δ
cli_func_v482.58% <80.00%> (-0.01%)⬇️
py_func_v481.07% <60.00%> (-0.03%)⬇️
unit87.01% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/base.py100.00% <100.00%> (ø)
gitlab/mixins.py92.30% <100.00%> (ø)

@nejch
Copy link
Member

@JohnVillalovos I don't mind this but I think it would be good to merge with a real-world use case implemented along with it, as currently this does not do anything. WDYT?

@JohnVillalovos
Copy link
MemberAuthor

@JohnVillalovos I don't mind this but I think it would be good to merge with a real-world use case implemented along with it, as currently this does not do anything. WDYT?

Sure. Will update it either today or tomorrow.

@JohnVillalovosJohnVillalovos marked this pull request as draftJune 21, 2022 15:49
@JohnVillalovos
Copy link
MemberAuthor

@JohnVillalovos I don't mind this but I think it would be good to merge with a real-world use case implemented along with it, as currently this does not do anything. WDYT?

Good idea. I added a real-world use case at the same time.

@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewJuly 6, 2022 05:30
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/mark_lazy_state branch 2 times, most recently from7c668e0 to7b4eceaCompareJuly 12, 2022 15:08
@nejch
Copy link
Member

Thanks@JohnVillalovos, just one more comment on the warning message, as I think it might be confusing if it raises for a real error on a method typo or so :)

This can be used to tell if a `RESTObject` was created using`lazy=True`.Add a message to the `AttributeError` if attribute access fails for aninstance created with `lazy=True`.
@nejchnejch merged commit2c90fd0 intomainJul 20, 2022
@nejchnejch deleted the jlvillal/mark_lazy_state branchJuly 20, 2022 19:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp