- Notifications
You must be signed in to change notification settings - Fork673
test(projects): add unit tests for projects#2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0ab434d
tocde78a9
Comparecde78a9
to67942f0
CompareUh oh!
There was an error while loading.Please reload this page.
codecov-commenter commentedJun 16, 2022
Codecov Report
@@ Coverage Diff @@## main #2069 +/- ##==========================================+ Coverage 94.64% 95.26% +0.61%========================================== Files 78 78 Lines 5003 5003 ==========================================+ Hits 4735 4766 +31+ Misses 268 237 -31
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
antoineauger commentedJun 16, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nejch Here is a first try to reach the 100% coverage for 🏓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for all the work here@antoineauger 😮 I left only some tiny comment but it's non-blocking. I think we can leave the duplicate for now as we have to do more cleanup in other parts.
I realize adding the response fixtures now is quite tedious, will probably need to think of some lightweight wrappers to make it more manageable.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
antoineauger commentedJun 29, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for the valuable feedback@nejch, I think I addressed all your remarks. Back to you for final check 🏓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great, thanks again@antoineauger! Really happy to see this done, it was open for a long time :)
Uh oh!
There was an error while loading.Please reload this page.
Closes#1708
🛠️ with ❤️ bySiemens