Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(projects): add unit tests for projects#2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

antoineauger
Copy link
Contributor

@antoineaugerantoineauger commentedJun 14, 2022
edited
Loading

Closes#1708

🛠️ with ❤️ bySiemens

@antoineaugerantoineaugerforce-pushed thetest/unit-tests-projects branch 2 times, most recently from0ab434d tocde78a9CompareJune 15, 2022 16:17
@antoineaugerantoineaugerforce-pushed thetest/unit-tests-projects branch fromcde78a9 to67942f0CompareJune 16, 2022 08:53
@codecov-commenter
Copy link

Codecov Report

Merging#2069 (67942f0) intomain (ca98d88) willincrease coverage by0.61%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #2069      +/-   ##==========================================+ Coverage   94.64%   95.26%   +0.61%==========================================  Files          78       78                Lines        5003     5003              ==========================================+ Hits         4735     4766      +31+ Misses        268      237      -31
FlagCoverage Δ
cli_func_v482.45% <ø> (ø)
py_func_v481.03% <ø> (ø)
unit86.78% <ø> (+1.17%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/push_rules.py100.00% <0.00%> (+6.66%)⬆️
gitlab/v4/objects/projects.py100.00% <0.00%> (+10.06%)⬆️

@antoineaugerantoineauger marked this pull request as ready for reviewJune 16, 2022 09:04
@antoineauger
Copy link
ContributorAuthor

antoineauger commentedJun 16, 2022
edited
Loading

@nejch Here is a first try to reach the 100% coverage forprojects/push_rules objects 😄

🏓

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for all the work here@antoineauger 😮 I left only some tiny comment but it's non-blocking. I think we can leave the duplicate for now as we have to do more cleanup in other parts.

I realize adding the response fixtures now is quite tedious, will probably need to think of some lightweight wrappers to make it more manageable.

antoineauger reacted with thumbs up emoji
@antoineauger
Copy link
ContributorAuthor

antoineauger commentedJun 29, 2022
edited
Loading

Thanks a lot for all the work here@antoineauger open_mouth I left only some tiny comment but it's non-blocking. I think we can leave the duplicate for now as we have to do more cleanup in other parts.

I realize adding the response fixtures now is quite tedious, will probably need to think of some lightweight wrappers to make it more manageable.

Thanks for the valuable feedback@nejch, I think I addressed all your remarks. Back to you for final check 🏓

@antoineaugerantoineauger requested a review fromnejchJune 29, 2022 09:02
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks again@antoineauger! Really happy to see this done, it was open for a long time :)

antoineauger reacted with thumbs up emoji
@nejchnejch merged commit0e4db56 intopython-gitlab:mainJun 29, 2022
@antoineaugerantoineauger deleted the test/unit-tests-projects branchJune 29, 2022 09:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@max-wittigmax-wittigmax-wittig left review comments

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests need to be implemented for tests/unit/test_projects.py
4 participants
@antoineauger@codecov-commenter@max-wittig@nejch

[8]ページ先頭

©2009-2025 Movatter.jp